New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ulimits to unsupported compose fields #482

Merged
merged 1 commit into from Aug 29, 2017

Conversation

Projects
None yet
6 participants
@dnephin
Collaborator

dnephin commented Aug 29, 2017

Add ulimits to unsupported compose fields.
Signed-off-by: Daniel Nephin <dnephin@docker.com>
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Aug 29, 2017

Codecov Report

Merging #482 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #482      +/-   ##
==========================================
+ Coverage   48.62%   48.62%   +<.01%     
==========================================
  Files         199      199              
  Lines       16396    16396              
==========================================
+ Hits         7972     7973       +1     
+ Misses       8008     8007       -1     
  Partials      416      416

codecov-io commented Aug 29, 2017

Codecov Report

Merging #482 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #482      +/-   ##
==========================================
+ Coverage   48.62%   48.62%   +<.01%     
==========================================
  Files         199      199              
  Lines       16396    16396              
==========================================
+ Hits         7972     7973       +1     
+ Misses       8008     8007       -1     
  Partials      416      416

@dnephin dnephin referenced this pull request Aug 29, 2017

Closed

elasticsearch on swarm cluster, ulimits ignored #88

2 of 3 tasks complete

@dnephin dnephin requested a review from vieux Aug 29, 2017

@boaz1337

LGTM

@vieux

vieux approved these changes Aug 29, 2017

LGTM

@dnephin dnephin merged commit 65202d6 into docker:master Aug 29, 2017

9 checks passed

ci/circleci: cross Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: shellcheck Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing e600621...bdc8cf3
Details
codecov/project 48.62% (+<.01%) compared to e600621
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
dco-signed All commits are signed

@GordonTheTurtle GordonTheTurtle added this to the 17.08.0 milestone Aug 29, 2017

@dnephin dnephin deleted the dnephin:add-ulimit-to-unsupported branch Aug 29, 2017

@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah Sep 26, 2017

Member

ping @londoncalling does this need documentation changes?

Member

thaJeztah commented Sep 26, 2017

ping @londoncalling does this need documentation changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment