New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move output of stack rm to stdout #491

Merged
merged 1 commit into from Sep 4, 2017

Conversation

Projects
None yet
6 participants
@FrenchBen
Contributor

FrenchBen commented Sep 1, 2017

- What I did
Updated the output of docker stack rm to be sent to stdout.

Fixes #490

- How I did it
s/Err/Out

- How to verify it
With no errors, doing docker stack rm nginx 1>stdout.log 2>stderr.log should show all output in stdout

- Description for the changelog
docker stack rm now sends info messages to Stdout

- A picture of a cute animal (not mandatory but encouraged)
doge

@dnephin

This comment has been minimized.

Show comment
Hide comment
@dnephin

dnephin Sep 1, 2017

Collaborator

Why should it go to stdout?

Collaborator

dnephin commented Sep 1, 2017

Why should it go to stdout?

@FrenchBen

This comment has been minimized.

Show comment
Hide comment
@FrenchBen
Contributor

FrenchBen commented Sep 1, 2017

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Sep 1, 2017

Codecov Report

Merging #491 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master    #491   +/-   ##
======================================
  Coverage    48.8%   48.8%           
======================================
  Files         199     199           
  Lines       16389   16389           
======================================
  Hits         7998    7998           
  Misses       7976    7976           
  Partials      415     415

codecov-io commented Sep 1, 2017

Codecov Report

Merging #491 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master    #491   +/-   ##
======================================
  Coverage    48.8%   48.8%           
======================================
  Files         199     199           
  Lines       16389   16389           
======================================
  Hits         7998    7998           
  Misses       7976    7976           
  Partials      415     415
@dnephin

This comment has been minimized.

Show comment
Hide comment
@dnephin

dnephin Sep 1, 2017

Collaborator

Ok, makes sense to be consistent with the other remove commands.

The e2e test needs to be fixed as well

Collaborator

dnephin commented Sep 1, 2017

Ok, makes sense to be consistent with the other remove commands.

The e2e test needs to be fixed as well

@dnephin

dnephin approved these changes Sep 1, 2017

LGTM with a squash

"Removing config bar_config1",
"Removing network bar_network1\n",
}
assert.Equal(t, strings.Join(expectedList, "\n"), fakeCli.OutBuffer().String())
assert.Contains(t, fakeCli.ErrBuffer().String(), "Nothing found in stack: foo\n")

This comment has been minimized.

@dnephin

dnephin Sep 1, 2017

Collaborator

hmm, actually this seems weird. Why is it outputing both "nothing found in stack" and that it's removing things?

Not sure how this is passing. Something seems wrong

@dnephin

dnephin Sep 1, 2017

Collaborator

hmm, actually this seems weird. Why is it outputing both "nothing found in stack" and that it's removing things?

Not sure how this is passing. Something seems wrong

This comment has been minimized.

@dnephin

dnephin Sep 1, 2017

Collaborator

Oh, nevermind, I see it now. There are two stacks, one is empty, the other is not.

@dnephin

dnephin Sep 1, 2017

Collaborator

Oh, nevermind, I see it now. There are two stacks, one is empty, the other is not.

@FrenchBen

This comment has been minimized.

Show comment
Hide comment
@FrenchBen

FrenchBen Sep 1, 2017

Contributor

Can you squash on merge?

Contributor

FrenchBen commented Sep 1, 2017

Can you squash on merge?

French Ben
Move output of stack rm to stdout
Signed-off-by: French Ben <frenchben@docker.com>

Update for the test to capture the proper removal

Signed-off-by: French Ben <frenchben@docker.com>

Satisfy lint length limit

Signed-off-by: French Ben <frenchben@docker.com>

Updated e2e test

Signed-off-by: French Ben <frenchben@docker.com>
@vdemeester

LGTM 🐮

@vdemeester vdemeester merged commit 38c1895 into docker:master Sep 4, 2017

9 checks passed

ci/circleci: cross Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: shellcheck Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 50%)
Details
codecov/project 48.8% (+0%) compared to d861a1c
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
dco-signed All commits are signed

@GordonTheTurtle GordonTheTurtle added this to the 17.08.0 milestone Sep 4, 2017

@FrenchBen FrenchBen deleted the FrenchBen:fix-stack branch Sep 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment