New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set APIVersion on the client, even when Ping fails #546

Merged
merged 1 commit into from Sep 23, 2017

Conversation

Projects
None yet
6 participants
@dnephin
Collaborator

dnephin commented Sep 20, 2017

Fixes #149

Refactor to support testing
Also add tests

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Sep 20, 2017

Codecov Report

Merging #546 into master will increase coverage by 0.14%.
The diff coverage is 79.31%.

@@            Coverage Diff             @@
##           master     #546      +/-   ##
==========================================
+ Coverage   49.08%   49.23%   +0.14%     
==========================================
  Files         200      200              
  Lines       16447    16453       +6     
==========================================
+ Hits         8073     8100      +27     
+ Misses       7954     7933      -21     
  Partials      420      420

codecov-io commented Sep 20, 2017

Codecov Report

Merging #546 into master will increase coverage by 0.14%.
The diff coverage is 79.31%.

@@            Coverage Diff             @@
##           master     #546      +/-   ##
==========================================
+ Coverage   49.08%   49.23%   +0.14%     
==========================================
  Files         200      200              
  Lines       16447    16453       +6     
==========================================
+ Hits         8073     8100      +27     
+ Misses       7954     7933      -21     
  Partials      420      420
@vdemeester

LGTM 🐄 Just one question 👼

Show outdated Hide outdated cli/command/cli_test.go
Set APIVersion on the client, even when Ping fails
Refactor to support testing
Also add tests

Signed-off-by: Daniel Nephin <dnephin@docker.com>
@cpuguy83

LGTM

@cpuguy83 cpuguy83 merged commit a41caad into docker:master Sep 23, 2017

9 checks passed

ci/circleci: cross Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: shellcheck Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
codecov/patch 79.31% of diff hit (target 50%)
Details
codecov/project 49.23% (+0.14%) compared to 10e292d
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
dco-signed All commits are signed

@GordonTheTurtle GordonTheTurtle added this to the 17.10.0 milestone Sep 23, 2017

@dnephin dnephin deleted the dnephin:fix-version-on-failure branch Sep 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment