New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not truncate ID on docker service ps --quiet #579

Merged
merged 1 commit into from Oct 2, 2017

Conversation

Projects
None yet
5 participants
@thaJeztah
Member

thaJeztah commented Sep 30, 2017

fixes #543

Running docker service ps --quiet should print the
full, non-truncated ID, even if the --no-trunc option
is not set.

This patch disables truncation if the --quiet flag
is set.

- What I did

Updated the code to override options.noTrunc if options.quiet is set

- How to verify it

Run docker service ps <servicename> and verify that the full, non-truncated ID is printed.

- Description for the changelog

Print non-truncated task ID when using `docker service ps --quiet` [docker/cli#579](https://github.com/docker/cli/pull/579)

ping @stevvooe PTAL

Do not truncate ID on docker service ps --quiet
Running `docker service ps --quiet` should print the
full, non-truncated ID, even if the `--no-trunc` option
is not set.

This patch disables truncation if the `--quiet` flag
is set.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Sep 30, 2017

Codecov Report

Merging #579 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #579      +/-   ##
==========================================
+ Coverage   49.38%   49.41%   +0.03%     
==========================================
  Files         208      208              
  Lines       17178    17181       +3     
==========================================
+ Hits         8483     8490       +7     
+ Misses       8262     8259       -3     
+ Partials      433      432       -1

codecov-io commented Sep 30, 2017

Codecov Report

Merging #579 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #579      +/-   ##
==========================================
+ Coverage   49.38%   49.41%   +0.03%     
==========================================
  Files         208      208              
  Lines       17178    17181       +3     
==========================================
+ Hits         8483     8490       +7     
+ Misses       8262     8259       -3     
+ Partials      433      432       -1
@vdemeester

LGTM 🐸

@dnephin

dnephin approved these changes Oct 2, 2017

LGTM

@dnephin dnephin merged commit adfc2d1 into docker:master Oct 2, 2017

9 checks passed

ci/circleci: cross Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: shellcheck Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 50%)
Details
codecov/project 49.41% (+0.03%) compared to 583015b
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
dco-signed All commits are signed

@GordonTheTurtle GordonTheTurtle added this to the 17.11.0 milestone Oct 2, 2017

@thaJeztah thaJeztah deleted the thaJeztah:dont-trunc-on-quiet branch Oct 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment