New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rmi.md #580

Merged
merged 1 commit into from Oct 11, 2017

Conversation

Projects
None yet
5 participants
@djgoosen
Contributor

djgoosen commented Oct 2, 2017

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@GordonTheTurtle

This comment has been minimized.

Show comment
Hide comment
@GordonTheTurtle

GordonTheTurtle Oct 2, 2017

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "patch-1" git@github.com:djgoosen/cli.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

GordonTheTurtle commented Oct 2, 2017

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "patch-1" git@github.com:djgoosen/cli.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Oct 2, 2017

Codecov Report

Merging #580 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #580      +/-   ##
==========================================
- Coverage   49.41%   49.38%   -0.04%     
==========================================
  Files         208      208              
  Lines       17186    17178       -8     
==========================================
- Hits         8493     8483      -10     
- Misses       8261     8262       +1     
- Partials      432      433       +1

codecov-io commented Oct 2, 2017

Codecov Report

Merging #580 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #580      +/-   ##
==========================================
- Coverage   49.41%   49.38%   -0.04%     
==========================================
  Files         208      208              
  Lines       17186    17178       -8     
==========================================
- Hits         8493     8483      -10     
- Misses       8261     8262       +1     
- Partials      432      433       +1
@mistyhacks

Please sign your commit and use a more informative title for your pull request. Thanks!

Update rmi.md
Signed-off-by: Daniel Goosen <daniel.goosen@surveysampling.com>

@GordonTheTurtle GordonTheTurtle removed the dco/no label Oct 10, 2017

@thaJeztah

LGTM, thanks!

@thaJeztah thaJeztah merged commit 0a6e1cb into docker:master Oct 11, 2017

7 checks passed

ci/circleci: cross Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: shellcheck Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
dco-signed All commits are signed

@GordonTheTurtle GordonTheTurtle added this to the 17.11.0 milestone Oct 11, 2017

@djgoosen djgoosen deleted the djgoosen:patch-1 branch Oct 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment