New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dockerd reference heading levels #598

Merged
merged 1 commit into from Oct 5, 2017

Conversation

Projects
None yet
4 participants
@thaJeztah
Member

thaJeztah commented Oct 4, 2017

Commit ddadd3d (moby/moby#32569) changed the heading levels of various sections, but as a result, the "daemon configuration file" section (and other sections) changed from a H2 to a H4, therefore no longer showing up in the page's TOC / navigation bar.

screen shot 2017-10-04 at 18 06 07

This patch changes the heading level to a H3 for sections that should show up in the page navigation.

ping @mstanleyjones PTAL

Fix dockerd reference heading levels
Commit ddadd3d changed
the heading levels of various sections, but as a result,
the "daemon configuration file" section (and other sections)
changed from a H2 to a H4, therefore no longer showing
up in the page's TOC / navigation bar.

This patch changes the heading level to a H3 for
sections that should show up in the page navigation.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@vdemeester

LGTM 🐮

@thaJeztah thaJeztah merged commit 1649af8 into docker:master Oct 5, 2017

7 checks passed

ci/circleci: cross Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: shellcheck Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
dco-signed All commits are signed

@GordonTheTurtle GordonTheTurtle added this to the 17.11.0 milestone Oct 5, 2017

@thaJeztah thaJeztah deleted the thaJeztah:fix-dockerd-heading-levels branch Oct 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment