New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compose] Cast values to expected type after interpolating values #601

Merged
merged 4 commits into from Oct 26, 2017

Conversation

Projects
None yet
5 participants
@dnephin
Collaborator

dnephin commented Oct 4, 2017

Fixes #229

Required a change to the order of operations to handle interpolation before schema validation. This should be safe because interpolation should not require any specific structure.

cc @shin-
@vdemeester sorry in advance for conflicts with #569 if this merges first

dnephin added some commits Oct 3, 2017

Update interface of Interpolate
Signed-off-by: Daniel Nephin <dnephin@docker.com>
Vendor gotestyourself/env
Signed-off-by: Daniel Nephin <dnephin@docker.com>
Cast interpolated values
Signed-off-by: Daniel Nephin <dnephin@docker.com>

@dnephin dnephin requested a review from vdemeester as a code owner Oct 4, 2017

@dnephin dnephin requested review from vieux and thaJeztah Oct 5, 2017

Fix load order
Signed-off-by: Daniel Nephin <dnephin@docker.com>
@seriousben

This comment has been minimized.

Show comment
Hide comment
@seriousben

seriousben Oct 18, 2017

Would be amazing to get this soon :)

seriousben commented Oct 18, 2017

Would be amazing to get this soon :)

@vieux

vieux approved these changes Oct 18, 2017

LGTM

@vdemeester

LGTM 🐸

@dnephin dnephin merged commit b68c3d0 into docker:master Oct 26, 2017

7 checks passed

ci/circleci: cross Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: shellcheck Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
dco-signed All commits are signed

@dnephin dnephin deleted the dnephin:compose-cast-after-interpolate branch Oct 26, 2017

@GordonTheTurtle GordonTheTurtle added this to the 17.11.0 milestone Oct 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment