New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix markdown link in service-create reference docs #603

Merged
merged 1 commit into from Oct 5, 2017

Conversation

Projects
None yet
4 participants
@thaJeztah
Member

thaJeztah commented Oct 5, 2017

Markdown nested in a HTML table doesn't work, so changing the link to a plain HTML link.

fixes #602

ping @johndmulhausen @mstanleyjones

Fix markdown link in service-create reference docs
Markdown nested in a HTML table doesn't work, so changing
the link to a plain HTML link.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@vdemeester

LGTM 🐯

@@ -294,8 +294,9 @@ volumes in a service:
<td>
<p>The type of mount, can be either <tt>volume</tt>, <tt>bind</tt>, or <tt>tmpfs</tt>. Defaults to <tt>volume</tt> if no type is specified.
<ul>
<li><tt>volume</tt>: mounts a [managed volume](volume_create.md) into the container.</li>
<li><tt>bind</tt>: bind-mounts a directory or file from the host into the container.</li>
<li><tt>volume</tt>: mounts a <a href="https://docs.docker.com/engine/reference/commandline/volume_create/">managed volume</a>

This comment has been minimized.

@mistyhacks

mistyhacks Oct 5, 2017

Contributor

This is an OK fix. Alternatively, you could add markdown="span" as an attribute to the <li> and leave the Markdown in there. Your choice. I think you could also avoid the <tt> tags too, in favor of backticks.

@mistyhacks

mistyhacks Oct 5, 2017

Contributor

This is an OK fix. Alternatively, you could add markdown="span" as an attribute to the <li> and leave the Markdown in there. Your choice. I think you could also avoid the <tt> tags too, in favor of backticks.

This comment has been minimized.

@thaJeztah

thaJeztah Oct 5, 2017

Member

Oh, didn't know about that one! I think I'll keep it like this for now (mixing HTML and Markdown in a table may be confusing), but we could change it in a single go if we think it's better

@thaJeztah

thaJeztah Oct 5, 2017

Member

Oh, didn't know about that one! I think I'll keep it like this for now (mixing HTML and Markdown in a table may be confusing), but we could change it in a single go if we think it's better

@thaJeztah thaJeztah merged commit 0f659d9 into docker:master Oct 5, 2017

7 checks passed

ci/circleci: cross Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: shellcheck Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
dco-signed All commits are signed

@GordonTheTurtle GordonTheTurtle added this to the 17.11.0 milestone Oct 5, 2017

@thaJeztah thaJeztah deleted the thaJeztah:fix-service-create-markdown branch Oct 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment