New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bash completion and deprecation for synchronous service updates #610

Merged
merged 2 commits into from Oct 7, 2017

Conversation

Projects
None yet
4 participants
@albers
Member

albers commented Oct 7, 2017

The default value for docker service create|update|scale|rollback --detach|-d changed from true to false.
This updates bash completion to complete just --detach|-d.

This should go into 17.10.0 because the behavior changes in this release.

Also updates the deprecation of asynchronous service updates:

  • The default was not changed in 17.09 but will be in 17.10
  • service scale and service rollback are also affected.

albers added some commits Oct 7, 2017

Update bash completion for synchronous `docker service` commands
The default value for
`docker service create|update|scale|rollback --detach|-d` changed from
`true` to `false`.
This updates bash completion to complete just `--detach|-d`.

Signed-off-by: Harald Albers <github@albersweb.de>
Update deprecation for synchronous service updates
- The default was not changed in 17.09 but will be in 17.10
- `service scale` and `service rollback` are also affected.

Signed-off-by: Harald Albers <github@albersweb.de>
@thaJeztah

LGTM, thank you!

@albers albers referenced this pull request Oct 7, 2017

Closed

Fix changelog for `--detach` #262

@vdemeester

LGTM 🐯

@vdemeester vdemeester merged commit e3c580c into docker:master Oct 7, 2017

7 checks passed

ci/circleci: cross Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: shellcheck Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
dco-signed All commits are signed

@albers albers deleted the albers:completion-service--detach branch Oct 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment