New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bash completion for `secret create --driver` #618

Merged
merged 1 commit into from Oct 11, 2017

Conversation

Projects
None yet
5 participants
@albers
Member

albers commented Oct 11, 2017

Bash completion for #366

Add bash completion for `secret create --driver`
Signed-off-by: Harald Albers <github@albersweb.de>
@albers

This comment has been minimized.

Show comment
Hide comment
@albers

albers Oct 11, 2017

Member

This should go into 17.10.0 as the feature is present in that release:

$ docker secret create --help

Usage:  docker secret create [OPTIONS] SECRET [file|-]

Create a secret from a file or STDIN as content

Options:
  -d, --driver string   Secret driver
      --help            Print usage
  -l, --label list      Secret labels
$ docker --version
Docker version 17.10.0-ce-rc1, build d866876
Member

albers commented Oct 11, 2017

This should go into 17.10.0 as the feature is present in that release:

$ docker secret create --help

Usage:  docker secret create [OPTIONS] SECRET [file|-]

Create a secret from a file or STDIN as content

Options:
  -d, --driver string   Secret driver
      --help            Print usage
  -l, --label list      Secret labels
$ docker --version
Docker version 17.10.0-ce-rc1, build d866876

@albers albers added this to the 17.10.0 milestone Oct 11, 2017

@vdemeester vdemeester requested review from dnephin, thaJeztah and mlaventure Oct 11, 2017

@vdemeester

LGTM 🐮

@dnephin dnephin merged commit 5c9784e into docker:master Oct 11, 2017

7 checks passed

ci/circleci: cross Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: shellcheck Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
dco-signed All commits are signed

@albers albers deleted the albers:completion-secret-create--driver branch Oct 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment