New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flag description for --host-add #648

Merged
merged 1 commit into from Oct 30, 2017

Conversation

Projects
None yet
6 participants
@thaJeztah
Member

thaJeztah commented Oct 28, 2017

The --host-add flag adds a new host:ip mapping. Even though adding an entry is idempotent (adding the same mapping multiple times does not update the service's definition), it does not update an existing mapping with a new IP-address (multiple IP-addresses can be defined for a host).

This patch removes the "or update" part from the flag's description.

relates to moby/moby#35325

There's possibly some other flags that fall in the same category, but I kept those out for now (can do a follow up)

ping @vdemeester @dnephin PTAL

Fix flag description for --host-add
The `--host-add` flag adds a new `host:ip` mapping. Even though
adding an entry is idempotent (adding the same mapping multiple
times does not update the service's definition), it does not
_update_  an existing mapping with a new IP-address (multiple
IP-addresses can be defined for a host).

This patch removes the "or update" part from the flag's
description.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Oct 28, 2017

Codecov Report

Merging #648 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #648      +/-   ##
=========================================
- Coverage    49.8%   49.8%   -0.01%     
=========================================
  Files         210     210              
  Lines       17292   17292              
=========================================
- Hits         8613    8612       -1     
- Misses       8253    8254       +1     
  Partials      426     426

codecov-io commented Oct 28, 2017

Codecov Report

Merging #648 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #648      +/-   ##
=========================================
- Coverage    49.8%   49.8%   -0.01%     
=========================================
  Files         210     210              
  Lines       17292   17292              
=========================================
- Hits         8613    8612       -1     
- Misses       8253    8254       +1     
  Partials      426     426
@boaz1337

LGTM

@vdemeester

LGTM 🐮

@dnephin

LGTM

@dnephin dnephin merged commit a79e742 into docker:master Oct 30, 2017

9 checks passed

ci/circleci: cross Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: shellcheck Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 50%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +50.19% compared to 7ed96d3
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
dco-signed All commits are signed

@GordonTheTurtle GordonTheTurtle added this to the 17.11.0 milestone Oct 30, 2017

@thaJeztah thaJeztah deleted the thaJeztah:fix-host-add-description branch Oct 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment