New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated "daemon" subcommand #689

Merged
merged 1 commit into from Nov 23, 2017

Conversation

Projects
None yet
6 participants
@thaJeztah
Member

thaJeztah commented Nov 13, 2017

The docker daemon subcommand was only present for backward compatibility, but deprecated in v1.13 (moby/moby#26834), and scheduled for removal in v17.12

- Description for the changelog

* Remove deprecated `docker daemon` command [docker/cli#689](https://github.com/docker/cli/pull/689)
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Nov 13, 2017

Codecov Report

Merging #689 into master will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #689      +/-   ##
==========================================
+ Coverage   50.49%   50.57%   +0.07%     
==========================================
  Files         216      215       -1     
  Lines       17723    17678      -45     
==========================================
- Hits         8950     8941       -9     
+ Misses       8324     8290      -34     
+ Partials      449      447       -2

codecov-io commented Nov 13, 2017

Codecov Report

Merging #689 into master will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #689      +/-   ##
==========================================
+ Coverage   50.49%   50.57%   +0.07%     
==========================================
  Files         216      215       -1     
  Lines       17723    17678      -45     
==========================================
- Hits         8950     8941       -9     
+ Misses       8324     8290      -34     
+ Partials      449      447       -2
@vdemeester

LGTM 🐯

@dnephin

-tags daemon can also be removed from scripts/test/unit

@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah Nov 13, 2017

Member

Ah, yes, I started looking for that one; let me do that in this PR as well 👍

Member

thaJeztah commented Nov 13, 2017

Ah, yes, I started looking for that one; let me do that in this PR as well 👍

Remove deprecated "daemon" subcommand
The `docker daemon` subcommand was only present for
backward compatibility, but deprecated in v1.13,
and scheduled for removal in v17.12

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah Nov 13, 2017

Member

Updated: removed the -tags daemon from scripts/test/unit

Member

thaJeztah commented Nov 13, 2017

Updated: removed the -tags daemon from scripts/test/unit

@dnephin dnephin merged commit 227dfea into docker:master Nov 23, 2017

9 checks passed

ci/circleci: cross Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: shellcheck Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 365c525...c6a3199
Details
codecov/project 50.57% (+0.07%) compared to 365c525
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
dco-signed All commits are signed

@GordonTheTurtle GordonTheTurtle added this to the 17.12.0 milestone Nov 23, 2017

@thaJeztah thaJeztah deleted the thaJeztah:remove-daemon-subcommand branch Nov 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment