New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix external networks in stacks #743

Merged
merged 1 commit into from Dec 12, 2017

Conversation

Projects
None yet
5 participants
@dnephin
Collaborator

dnephin commented Dec 11, 2017

Fixes moby/moby#35755

Looks like I missed where the network name was used. I confirmed External.Name is no longer used anywhere after this patch.

Fix external networks
Signed-off-by: Daniel Nephin <dnephin@docker.com>

@dnephin dnephin requested a review from vdemeester as a code owner Dec 11, 2017

@dnephin dnephin added this to the 17.12.0 milestone Dec 11, 2017

@vdemeester

LGTM 🦁

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Dec 11, 2017

Codecov Report

Merging #743 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #743   +/-   ##
=======================================
  Coverage   53.45%   53.45%           
=======================================
  Files         218      218           
  Lines       14613    14613           
=======================================
  Hits         7811     7811           
  Misses       6321     6321           
  Partials      481      481

codecov-io commented Dec 11, 2017

Codecov Report

Merging #743 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #743   +/-   ##
=======================================
  Coverage   53.45%   53.45%           
=======================================
  Files         218      218           
  Lines       14613    14613           
=======================================
  Hits         7811     7811           
  Misses       6321     6321           
  Partials      481      481

@dnephin dnephin requested a review from andrewhsu Dec 11, 2017

@thaJeztah

LGTM

@thaJeztah thaJeztah merged commit eb5e32e into docker:master Dec 12, 2017

9 checks passed

ci/circleci: cross Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: shellcheck Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 50%)
Details
codecov/project 53.45% (+0%) compared to 29d3510
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
dco-signed All commits are signed

@dnephin dnephin deleted the dnephin:compose-add-name-to-network branch Mar 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment