New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix anchors to "Storage driver options" #748

Merged
merged 1 commit into from Dec 13, 2017

Conversation

Projects
None yet
5 participants
@thaJeztah
Member

thaJeztah commented Dec 13, 2017

Fixes #737

ping @johndmulhausen @mistyhacks PTAL

Fix anchors to "Storage driver options"
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Dec 13, 2017

Codecov Report

Merging #748 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #748   +/-   ##
=======================================
  Coverage   53.45%   53.45%           
=======================================
  Files         218      218           
  Lines       14613    14613           
=======================================
  Hits         7811     7811           
  Misses       6321     6321           
  Partials      481      481

codecov-io commented Dec 13, 2017

Codecov Report

Merging #748 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #748   +/-   ##
=======================================
  Coverage   53.45%   53.45%           
=======================================
  Files         218      218           
  Lines       14613    14613           
=======================================
  Hits         7811     7811           
  Misses       6321     6321           
  Partials      481      481
@vdemeester

LGTM 🐸

@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah Dec 13, 2017

Member

Author LGTM

Member

thaJeztah commented Dec 13, 2017

Author LGTM

@thaJeztah thaJeztah merged commit 6a2b9d0 into docker:master Dec 13, 2017

9 checks passed

ci/circleci: cross Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: shellcheck Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing eb5e32e...630f8b1
Details
codecov/project 53.45% remains the same compared to eb5e32e
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
dco-signed All commits are signed

@GordonTheTurtle GordonTheTurtle added this to the 18.01.0 milestone Dec 13, 2017

@thaJeztah thaJeztah deleted the thaJeztah:fix-storage-driver-anchors branch Dec 13, 2017

@johndmulhausen

This comment has been minimized.

Show comment
Hide comment
@johndmulhausen

johndmulhausen Dec 13, 2017

Contributor

LGTM too, thanks for the ping @thaJeztah

Contributor

johndmulhausen commented Dec 13, 2017

LGTM too, thanks for the ping @thaJeztah

@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah Dec 13, 2017

Member

Cherry pick for 17.12 here; docker/docker-ce#352

Member

thaJeztah commented Dec 13, 2017

Cherry pick for 17.12 here; docker/docker-ce#352

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment