New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for generic resources to bash completion #749

Merged
merged 1 commit into from Dec 15, 2017

Conversation

Projects
None yet
5 participants
@albers
Member

albers commented Dec 13, 2017

Adds bash completion for #429:

  • service create --generic-resource
  • service update --generic-resource-(add|rm)
  • dockerd --node-generic-resource
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Dec 13, 2017

Codecov Report

Merging #749 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #749   +/-   ##
=======================================
  Coverage   53.45%   53.45%           
=======================================
  Files         218      218           
  Lines       14613    14613           
=======================================
  Hits         7811     7811           
  Misses       6321     6321           
  Partials      481      481

codecov-io commented Dec 13, 2017

Codecov Report

Merging #749 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #749   +/-   ##
=======================================
  Coverage   53.45%   53.45%           
=======================================
  Files         218      218           
  Lines       14613    14613           
=======================================
  Hits         7811     7811           
  Misses       6321     6321           
  Partials      481      481
@thaJeztah

one nit, but LGTM otherwise

Show outdated Hide outdated contrib/completion/bash/docker Outdated
Add support for generic resources to bash completion
Adds bash completion for
- `service create --generic-resource`
- `service update --generic-resource-(add|rm)`
- `dockerd --node-generic-resource`

Signed-off-by: Harald Albers <github@albersweb.de>
@vdemeester

LGTM 🎉

@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah Dec 15, 2017

Member

😄 thanks!

merging, so that I can cherry-pick

Member

thaJeztah commented Dec 15, 2017

😄 thanks!

merging, so that I can cherry-pick

@thaJeztah thaJeztah merged commit 8684b99 into docker:master Dec 15, 2017

9 checks passed

ci/circleci: cross Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: shellcheck Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing ee3ffd6...8ec80ee
Details
codecov/project 53.45% remains the same compared to ee3ffd6
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
dco-signed All commits are signed

@GordonTheTurtle GordonTheTurtle added this to the 18.01.0 milestone Dec 15, 2017

@albers albers deleted the albers:completion--generic-resource branch Dec 15, 2017

@thaJeztah thaJeztah modified the milestones: 18.01.0, 17.12.0 Dec 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment