New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in zsh completion script for docker exec #751

Merged
merged 1 commit into from Dec 14, 2017

Conversation

Projects
None yet
5 participants
@ktrysmt
Contributor

ktrysmt commented Dec 13, 2017

fixes #750

- What I did
Fix the bug of docker exec at zsh completions.

- How I did it
add only one character.

- How to verify it
Visually?

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@GordonTheTurtle

This comment has been minimized.

Show comment
Hide comment
@GordonTheTurtle

GordonTheTurtle Dec 13, 2017

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "fix/zsh-completions" git@github.com:ktrysmt/cli.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

GordonTheTurtle commented Dec 13, 2017

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "fix/zsh-completions" git@github.com:ktrysmt/cli.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@ktrysmt

This comment has been minimized.

Show comment
Hide comment
@ktrysmt

ktrysmt Dec 13, 2017

Contributor

Excuse me, I will sign it.

Contributor

ktrysmt commented Dec 13, 2017

Excuse me, I will sign it.

Fixed #750
Signed-off-by: Kotaro Yoshimatsu <kotaro.yoshimatsu@gmail.com>

@GordonTheTurtle GordonTheTurtle removed the dco/no label Dec 13, 2017

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Dec 13, 2017

Codecov Report

Merging #751 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #751      +/-   ##
==========================================
- Coverage   53.45%   53.44%   -0.01%     
==========================================
  Files         218      218              
  Lines       14613    14613              
==========================================
- Hits         7811     7810       -1     
- Misses       6321     6322       +1     
  Partials      481      481

codecov-io commented Dec 13, 2017

Codecov Report

Merging #751 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #751      +/-   ##
==========================================
- Coverage   53.45%   53.44%   -0.01%     
==========================================
  Files         218      218              
  Lines       14613    14613              
==========================================
- Hits         7811     7810       -1     
- Misses       6321     6322       +1     
  Partials      481      481
@thaJeztah

LGTM, thanks!

@thaJeztah thaJeztah changed the title from Fixed #750 to Fix error in zsh completion script for docker exec Dec 14, 2017

@dnephin

LGTM

@thaJeztah thaJeztah merged commit ee3ffd6 into docker:master Dec 14, 2017

9 checks passed

ci/circleci: cross Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: shellcheck Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 619c40f...db05d8a
Details
codecov/project 53.44% (-0.01%) compared to 619c40f
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
dco-signed All commits are signed

@GordonTheTurtle GordonTheTurtle added this to the 18.01.0 milestone Dec 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment