New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated deprecation status for "repository:shortid" #753

Merged
merged 1 commit into from Dec 15, 2017

Conversation

Projects
None yet
5 participants
@thaJeztah
Member

thaJeztah commented Dec 13, 2017

Depends on moby/moby#35790

The repository:shortid syntax for referencing images is very little used,
collides with with tag references can be confused with digest references.

The repository:shortid notation was deprecated in Docker 1.13, and scheduled
for removal in Docker 17.12.

This patch updates the deprecation status for this feature.

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Dec 13, 2017

Codecov Report

Merging #753 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #753   +/-   ##
=======================================
  Coverage   53.45%   53.45%           
=======================================
  Files         218      218           
  Lines       14613    14613           
=======================================
  Hits         7811     7811           
  Misses       6321     6321           
  Partials      481      481

codecov-io commented Dec 13, 2017

Codecov Report

Merging #753 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #753   +/-   ##
=======================================
  Coverage   53.45%   53.45%           
=======================================
  Files         218      218           
  Lines       14613    14613           
=======================================
  Hits         7811     7811           
  Misses       6321     6321           
  Partials      481      481
**Target For Removal In Release: v17.12**
**Removed In Release: v17.12**
The `repository:shortid` syntax for referencing images is very little used,

This comment has been minimized.

@mistyhacks

mistyhacks Dec 14, 2017

Contributor

references, and can

@mistyhacks

mistyhacks Dec 14, 2017

Contributor

references, and can

This comment has been minimized.

@thaJeztah

thaJeztah Dec 14, 2017

Member

updated, PTAL

@thaJeztah

thaJeztah Dec 14, 2017

Member

updated, PTAL

Updated deprecation status for "repository:shortid"
The `repository:shortid` syntax for referencing images is very little used,
collides with with tag references can be confused with digest references.

The `repository:shortid` notation was deprecated in Docker 1.13, and scheduled
for removal in Docker 17.12.

This patch updates the deprecation status for this feature.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@vdemeester

LGTM 🦁

@thaJeztah thaJeztah changed the title from [Do not merge] Updated deprecation status for "repository:shortid" to Updated deprecation status for "repository:shortid" Dec 15, 2017

@thaJeztah thaJeztah merged commit 69b11da into docker:master Dec 15, 2017

9 checks passed

ci/circleci: cross Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: shellcheck Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 1d54f30...1a21ca1
Details
codecov/project 53.45% remains the same compared to 1d54f30
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
dco-signed All commits are signed

@GordonTheTurtle GordonTheTurtle added this to the 18.01.0 milestone Dec 15, 2017

@thaJeztah thaJeztah deleted the thaJeztah:image-shortid branch Dec 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment