New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "on-failure" restart policy being documented as "failure" #754

Merged
merged 1 commit into from Dec 14, 2017

Conversation

Projects
None yet
4 participants
@thaJeztah
Member

thaJeztah commented Dec 14, 2017

fixes docker/docker.github.io#5516

Commit ddadd3d#diff-505c72218d90da970c16fdbf0b4f613cL551 (#147) refactored the markdown documentation, but accidentally changed on-failure to failure.

This patch corrects this change.

Fix "on-failure" restart policy being documented as "failure"
Commit ddadd3d refactored
the markdown documentation, but accidentally changed
`on-failure` to `failure`.

This patch corrects this change.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah
Member

thaJeztah commented Dec 14, 2017

ping @mistyhacks PTAL

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Dec 14, 2017

Codecov Report

Merging #754 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #754   +/-   ##
=======================================
  Coverage   53.45%   53.45%           
=======================================
  Files         218      218           
  Lines       14613    14613           
=======================================
  Hits         7811     7811           
  Misses       6321     6321           
  Partials      481      481

codecov-io commented Dec 14, 2017

Codecov Report

Merging #754 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #754   +/-   ##
=======================================
  Coverage   53.45%   53.45%           
=======================================
  Files         218      218           
  Lines       14613    14613           
=======================================
  Hits         7811     7811           
  Misses       6321     6321           
  Partials      481      481
@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah Dec 14, 2017

Member

Author LGTM

Member

thaJeztah commented Dec 14, 2017

Author LGTM

@thaJeztah thaJeztah merged commit 1d54f30 into docker:master Dec 14, 2017

9 checks passed

ci/circleci: cross Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: shellcheck Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 6a2b9d0...43217d7
Details
codecov/project 53.45% remains the same compared to 6a2b9d0
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
dco-signed All commits are signed

@GordonTheTurtle GordonTheTurtle added this to the 18.01.0 milestone Dec 14, 2017

@thaJeztah thaJeztah deleted the thaJeztah:fix-on-failure branch Dec 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment