New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return errors from client in stack deploy configs #757

Merged
merged 1 commit into from Dec 19, 2017

Conversation

Projects
None yet
5 participants
@pszczekutowicz
Contributor

pszczekutowicz commented Dec 18, 2017

- What I did
Fixed #756

- How I did it
Added return statement.

- How to verify it

  1. Create stack with service and config
  2. Deploy stack
  3. Update config file content
  4. Deploy stack
  5. Deploy should end with error

- Description for the changelog
Return errors from daemon on stack deploy configs create/update

Return errors from client in stack deploy configs
Signed-off-by: Paweł Szczekutowicz <pszczekutowicz@gmail.com>

@GordonTheTurtle GordonTheTurtle removed the dco/no label Dec 18, 2017

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Dec 18, 2017

Codecov Report

Merging #757 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master     #757   +/-   ##
=======================================
  Coverage   53.45%   53.45%           
=======================================
  Files         218      218           
  Lines       14613    14613           
=======================================
  Hits         7811     7811           
  Misses       6321     6321           
  Partials      481      481

codecov-io commented Dec 18, 2017

Codecov Report

Merging #757 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master     #757   +/-   ##
=======================================
  Coverage   53.45%   53.45%           
=======================================
  Files         218      218           
  Lines       14613    14613           
=======================================
  Hits         7811     7811           
  Misses       6321     6321           
  Partials      481      481
@dnephin

LGTM, thanks!

@vdemeester

LGTM 🐯

@docker docker deleted a comment from GordonTheTurtle Dec 19, 2017

@vdemeester vdemeester merged commit 2b8eb23 into docker:master Dec 19, 2017

7 of 8 checks passed

codecov/patch 0% of diff hit (target 50%)
Details
ci/circleci: cross Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: shellcheck Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
codecov/project 53.45% remains the same compared to 718a245
Details
dco-signed All commits are signed

@GordonTheTurtle GordonTheTurtle added this to the 18.01.0 milestone Dec 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment