New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected descriptions for MAC_ADMIN and MAC_OVERRIDE #761

Merged
merged 1 commit into from Dec 21, 2017

Conversation

Projects
None yet
5 participants
@sourabhtk37
Contributor

sourabhtk37 commented Dec 21, 2017

The description for capabilities are mismatched for MAC_ADMIN and MAC_OVERRIDE.
You can find the correct information here on the linux man page.

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Dec 21, 2017

Codecov Report

Merging #761 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #761   +/-   ##
=======================================
  Coverage   53.45%   53.45%           
=======================================
  Files         218      218           
  Lines       14613    14613           
=======================================
  Hits         7811     7811           
  Misses       6321     6321           
  Partials      481      481

codecov-io commented Dec 21, 2017

Codecov Report

Merging #761 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #761   +/-   ##
=======================================
  Coverage   53.45%   53.45%           
=======================================
  Files         218      218           
  Lines       14613    14613           
=======================================
  Hits         7811     7811           
  Misses       6321     6321           
  Partials      481      481
Corrected descriptions for MAC_ADMIN and MAC_OVERRIDE
The description for capabilities are mismatched for MAC_ADMIN and MAC_OVERRIDE.

Signed-off-by: T K Sourabh <sourabhtk37@gmail.com>

@GordonTheTurtle GordonTheTurtle removed the dco/no label Dec 21, 2017

@docker docker deleted a comment from GordonTheTurtle Dec 21, 2017

@thaJeztah

LGTM, thanks!

@vdemeester

LGTM 👍
cc @thaJeztah

@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah Dec 21, 2017

Member

Looks like it was always swapped, and we never noticed; moby/moby#11861, nice catch @sourabhtk37!

Member

thaJeztah commented Dec 21, 2017

Looks like it was always swapped, and we never noticed; moby/moby#11861, nice catch @sourabhtk37!

@thaJeztah thaJeztah merged commit ebb8927 into docker:master Dec 21, 2017

8 checks passed

ci/circleci: cross Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: shellcheck Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 2f3b137...afcc78a
Details
codecov/project 53.45% remains the same compared to 2f3b137
Details
dco-signed All commits are signed

@GordonTheTurtle GordonTheTurtle added this to the 18.01.0 milestone Dec 21, 2017

@sourabhtk37

This comment has been minimized.

Show comment
Hide comment
@sourabhtk37

sourabhtk37 Dec 21, 2017

Contributor

No problem @thaJeztah

Contributor

sourabhtk37 commented Dec 21, 2017

No problem @thaJeztah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment