New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix description of filter flag in prune commands #774

Merged
merged 1 commit into from Jan 2, 2018

Conversation

Projects
None yet
5 participants
@apkd
Contributor

apkd commented Jan 2, 2018

- What I did
Fix description of filter flag in prune commands.

- How to verify it
None of the following work demonstrating the issue:

user@ubuntu:~$ docker image prune -f "until=24h"
"docker image prune" accepts no arguments.
See 'docker image prune --help'.

Usage:  docker image prune [OPTIONS] [flags]

Remove unused images
user@ubuntu:~$ docker volume prune -f "until=24h"
"docker volume prune" accepts no arguments.
See 'docker volume prune --help'.

Usage:  docker volume prune [OPTIONS] [flags]

Remove all unused volumes
user@ubuntu:~$ docker network prune -f "until=24h"
"docker network prune" accepts no arguments.
See 'docker network prune --help'.

Usage:  docker network prune [OPTIONS] [flags]

Remove all unused networks
user@ubuntu:~$ docker container prune -f "until=24h"
"docker container prune" accepts no arguments.
See 'docker container prune --help'.

Usage:  docker container prune [OPTIONS] [flags]

Remove all stopped containers
user@ubuntu:~$ docker system prune -f "until=24h"
"docker system prune" accepts no arguments.
See 'docker system prune --help'.

Usage:  docker system prune [OPTIONS] [flags]

Remove unused data

Correct output when the proper flag is used:

user@ubuntu:~$ docker image prune --filter "until=24h"
WARNING! This will remove all dangling images.
Are you sure you want to continue? [y/N] n
Total reclaimed space: 0B

- Description for the changelog
Fix description of filter flag in prune commands. The "-f" flag is an alias for --force, not --filter (as correctly stated at the top of each documents). The system_prune.md didn't have this error.

- A picture of a cute animal (not mandatory but encouraged)

Meerkats

Fix description of filter flag in prune commands
The "-f" flag is an alias for --force, not --filter (as correctly stated at the top of each documents). The system_prune.md didn't have this error.

Signed-off-by: Mateusz Major <apkd@users.noreply.github.com>
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Jan 2, 2018

Codecov Report

Merging #774 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #774   +/-   ##
=======================================
  Coverage   53.46%   53.46%           
=======================================
  Files         218      218           
  Lines       14642    14642           
=======================================
  Hits         7829     7829           
  Misses       6327     6327           
  Partials      486      486

codecov-io commented Jan 2, 2018

Codecov Report

Merging #774 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #774   +/-   ##
=======================================
  Coverage   53.46%   53.46%           
=======================================
  Files         218      218           
  Lines       14642    14642           
=======================================
  Hits         7829     7829           
  Misses       6327     6327           
  Partials      486      486
@dnephin

dnephin approved these changes Jan 2, 2018

LGTM

@vdemeester

LGTM 🦁

@vdemeester vdemeester merged commit 1a64b1b into docker:master Jan 2, 2018

8 checks passed

ci/circleci: cross Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: shellcheck Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing ae4af7e...8b07518
Details
codecov/project 53.46% remains the same compared to ae4af7e
Details
dco-signed All commits are signed

@GordonTheTurtle GordonTheTurtle added this to the 18.01.0 milestone Jan 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment