Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken Kubernetes stack flags #831

Merged
merged 1 commit into from Jan 24, 2018

Conversation

@silvin-lubecki
Copy link
Contributor

silvin-lubecki commented Jan 24, 2018

- What I did
I fixed the broken kubernetes stack flags namespace and kubeconfig.

- How I did it
I switched PersistentFlags to Flags while reading flags during the command run phase.

- How to verify it

  1. Deploy a kubernetes stack using default namespace
  2. docker stack ls --namespace myemptynamespace should print nothing

- Description for the changelog
Fix broken Kubernetes stack flags

- A picture of a cute animal (not mandatory but encouraged)
image

…to be defined in the "persistent space".

Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 24, 2018

Codecov Report

Merging #831 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master     #831   +/-   ##
=======================================
  Coverage   52.95%   52.95%           
=======================================
  Files         244      244           
  Lines       15828    15828           
=======================================
  Hits         8382     8382           
  Misses       6892     6892           
  Partials      554      554
Copy link
Collaborator

vdemeester left a comment

LGTM 🐯

Copy link
Member

thaJeztah left a comment

LGTM, thanks!

@thaJeztah thaJeztah merged commit f9039fe into docker:master Jan 24, 2018
7 of 8 checks passed
7 of 8 checks passed
codecov/patch 0% of diff hit (target 50%)
Details
ci/circleci: cross Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: shellcheck Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
codecov/project 52.95% remains the same compared to b6a628c
Details
dco-signed All commits are signed
@silvin-lubecki silvin-lubecki deleted the silvin-lubecki:fix-kubernetes-flags branch Jan 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.