Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect network name showed with --x-networking #2345

Closed
arun-gupta opened this Issue Nov 8, 2015 · 7 comments

Comments

Projects
None yet
5 participants
@arun-gupta
Copy link

arun-gupta commented Nov 8, 2015

Started an application using https://github.com/arun-gupta/docker-images/blob/master/wildfly-mysql-javaee7/docker-compose.yml as:

docker-compose --x-networking up -d
Creating network "wildflymysqljavaee7" with driver "None"
Creating wildflymysqljavaee7_mywildfly_1
Creating db

The message shows network is created with driver "None" but listing the network as docker network ls shows otherwise:

> docker network ls
NETWORK ID          NAME                  DRIVER
a3c9994d6134        none                  null                
91537bec6510        host                  host                
b1770955e5aa        wildflymysqljavaee7   bridge              
6fda61934fbe        bridge                bridge  
@dnephin

This comment has been minimized.

Copy link
Contributor

dnephin commented Dec 1, 2015

The log message needs to check if there is no driver specified, and say "default" instead of "None"

@nicolaka

This comment has been minimized.

Copy link

nicolaka commented Dec 9, 2015

@aanand @dnephin why is it that compose still creates an overlay network and names it $PROJECT_NAME even if all the services in docker-compose.yml file explicitly use a net: parameter that uses an existing overlay network ?

Is this behavior handing with this issue?

@aanand

This comment has been minimized.

Copy link
Contributor

aanand commented Dec 9, 2015

We probably shouldn't create the default network if nothing is going to use it, yeah.

@dnephin

This comment has been minimized.

Copy link
Contributor

dnephin commented Dec 9, 2015

Ya, that should have already been fixed in #2341 (#2275) which was part of 1.5.1.

@dbonev

This comment has been minimized.

Copy link
Contributor

dbonev commented Dec 10, 2015

Sorry, if it's a stupid question, but is the expected behaviour here to just output "default" (literally) instead of "None"?
I.e. in this particular case, what is the expected output:

  1. Creating network "wildflymysqljavaee7" with driver "default"
  2. Creating network "wildflymysqljavaee7" with driver "bridge"
    or maybe:
  3. Creating network "wildflymysqljavaee7" with the default driver

Again, sorry if that's obvious -- I'm a newbie in compose.

Thanks

@aanand

This comment has been minimized.

Copy link
Contributor

aanand commented Dec 10, 2015

Correct. (3) would be my preference.

@dbonev

This comment has been minimized.

Copy link
Contributor

dbonev commented Dec 10, 2015

#dibs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.