Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compose schema version 3.8 support #6530

Closed
chris-crone opened this issue Feb 20, 2019 · 7 comments
Closed

Compose schema version 3.8 support #6530

chris-crone opened this issue Feb 20, 2019 · 7 comments
Assignees
Milestone

Comments

@chris-crone
Copy link
Member

@chris-crone chris-crone commented Feb 20, 2019

Add support for Compose schema version 3.8 to bring in line with Docker CLI.

See: docker/cli#1410

@sirlatrom
Copy link

@sirlatrom sirlatrom commented Mar 23, 2019

Also see docker/cli#1746 (another new field in 3.8)

@sirlatrom
Copy link

@sirlatrom sirlatrom commented Mar 28, 2019

I'm hoping this one will make it in: docker/cli#1783, so in case it looks like it will, I'll be happy to contribute its counterpart in docker-compose.

@chris-crone
Copy link
Member Author

@chris-crone chris-crone commented Apr 1, 2019

@sirlatrom that'd be great, thanks!

@sirlatrom
Copy link

@sirlatrom sirlatrom commented Apr 1, 2019

@sirlatrom that'd be great, thanks!

As soon as I get an LGTM from @thaJeztah on docker/cli#1783, I'll push a PR for Compose 3.8. AFAICT it's just a bit of admin-like work by copying over the spec JSON file and adding references to it in a few places.

@aldoborrero
Copy link

@aldoborrero aldoborrero commented Jul 23, 2019

Any news on this issue? Is somebody working on it?

sirlatrom added a commit to sirlatrom/compose that referenced this issue Jul 29, 2019
Fixes docker#6530.

Signed-off-by: Sune Keller <absukl@almbrand.dk>
sirlatrom added a commit to sirlatrom/compose that referenced this issue Jul 29, 2019
Resolves docker#6530.

Signed-off-by: Sune Keller <absukl@almbrand.dk>
@sirlatrom
Copy link

@sirlatrom sirlatrom commented Jul 29, 2019

I believe #6823 resolves this issue.

sirlatrom added a commit to sirlatrom/compose that referenced this issue Aug 15, 2019
Resolves docker#6530.

Signed-off-by: Sune Keller <absukl@almbrand.dk>
@ulyssessouza ulyssessouza removed this from the 1.25.0 milestone Nov 14, 2019
@ulyssessouza ulyssessouza added this to the 1.26.0 milestone Nov 14, 2019
@aiordache aiordache self-assigned this Jan 21, 2020
@ndeloof
Copy link
Collaborator

@ndeloof ndeloof commented Jan 22, 2020

Don't forget to document changed introduced by 3.8 on https://docs.docker.com/compose/compose-file/compose-versioning/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

6 participants