New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Wordpress tutorial #3275

Merged
merged 1 commit into from Apr 8, 2016

Conversation

Projects
None yet
4 participants
@activatedgeek
Copy link
Contributor

activatedgeek commented Apr 6, 2016

The new tutorial now uses official Wordpress Docker Image.

@activatedgeek

This comment has been minimized.

Copy link
Contributor

activatedgeek commented Apr 7, 2016

@dnephin When can I expect this to go live?

@dnephin

This comment has been minimized.

Copy link
Contributor

dnephin commented Apr 7, 2016

@activatedgeek I don't have any estimate for you unfortunately.

cc @londoncalling for docs review


### Build the project

With those four new files in place, run `docker-compose up` from your project directory. This will pull and build the needed images, and then start the web and database containers.
With those four new files in place, run `docker-compose up -d` from your project directory. This will pull and build the needed images, and then start the wordpress and database containers.

This comment has been minimized.

@londoncalling

londoncalling Apr 8, 2016

Contributor

@dnephin something seems to be missing here, because as written:

  • this doesn't make sense anymore "with those four new files in place" (which 4 files? because now we don't tell them to create the other 3 files)
  • it doesn't run

I see that the docker-compose.yml file is calling different DB and Wordpress images, defining different volumes, etc., but how is the docker-compose.yml supposed to find what it needs? It doesn't seem to be working for me, whereas the original one did.

Also there doesn't seem to be a reference point for MariaDB comment. Where would I see that referenced? In one of the containers? In another config file?

@londoncalling

This comment has been minimized.

Copy link
Contributor

londoncalling commented Apr 8, 2016

@dnephin @activatedgeek please see my comments inline on the markdown file; I can't get the sample app to run by following the tutorial as is now

@activatedgeek activatedgeek force-pushed the activatedgeek:patch-1 branch from 21fd8a2 to 8ef9d11 Apr 8, 2016

Updated Wordpress tutorial
The new tutorial now uses official Wordpress Docker Image.

Signed-off-by: Sanyam Kapoor <1sanyamkapoor@gmail.com>

@activatedgeek activatedgeek force-pushed the activatedgeek:patch-1 branch from 8ef9d11 to d4e9a3b Apr 8, 2016

@activatedgeek

This comment has been minimized.

Copy link
Contributor

activatedgeek commented Apr 8, 2016

Hey @londoncalling, I updated the misleading old text in the document. Also I just ran a fresh project, created a folder, adding the docker compose file mentioned in the document and it works. I have done absolutely no modifications whatsoever to the wordpress or mysql docker images.

I have added an extra note as the containers take a couple of minutes to bootstrap on the first load. Once the setup is complete it should work as claimed.

@londoncalling

This comment has been minimized.

Copy link
Contributor

londoncalling commented Apr 8, 2016

@dnephin @activatedgeek yes it works now. Thanks for updating the wording, it reads very nicely. As for it not running before, I believe that was caused by some problems I was having with some in-development versions of Docker. All good now. LGTM!

I'm going to merge this and make a few more minor changes to it (e.g., add an abbreviated example output from the docker-compose up -d command, and format some things in that last step into a few separate paragraphs) Thanks!

@londoncalling londoncalling merged commit 80614cf into docker:master Apr 8, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
docker/dco-signed All commits signed
Details
documentation success
Details

@activatedgeek activatedgeek deleted the activatedgeek:patch-1 branch Apr 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment