Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--remove-orphans is ignored when using up --no-start #6342

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@collin5
Copy link
Contributor

commented Nov 15, 2018

Resolves #5547

@shin-
Copy link
Contributor

left a comment

One small improvement to consider. Can you also add a test to ensure the new behavior is applied? Thanks!

Show resolved Hide resolved compose/project.py Outdated
@GordonTheTurtle

This comment has been minimized.

Copy link

commented Nov 27, 2018

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "b5547" git@github.com:collin5/compose.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354176728
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@collin5 collin5 force-pushed the collin5:b5547 branch from f34ed0f to 91f9538 Nov 27, 2018

@GordonTheTurtle GordonTheTurtle removed the dco/no label Nov 27, 2018

@collin5 collin5 force-pushed the collin5:b5547 branch from 91f9538 to a198c04 Nov 27, 2018

@collin5

This comment has been minimized.

Copy link
Contributor Author

commented Nov 27, 2018

Updated. Thank you!

Show resolved Hide resolved compose/project.py Outdated

@collin5 collin5 force-pushed the collin5:b5547 branch 2 times, most recently from 967cadd to 8e5c3fa Nov 28, 2018

@collin5

This comment has been minimized.

Copy link
Contributor Author

commented Nov 28, 2018

Fixed! Thanks

@ulyssessouza

This comment has been minimized.

Copy link
Collaborator

commented Jan 25, 2019

Thank you @collin5 !
Could you please, squash the 3 commits?

remove stopped containers on --remove-orphans
Signed-off-by: Collins Abitekaniza <abtcolns@gmail.com>

kill orphan containers, catch APIError Exception

Signed-off-by: Collins Abitekaniza <abtcolns@gmail.com>

test remove orphans with --no-start

Signed-off-by: Collins Abitekaniza <abtcolns@gmail.com>

@collin5 collin5 force-pushed the collin5:b5547 branch from 8e5c3fa to c27132a Jan 25, 2019

@collin5

This comment has been minimized.

Copy link
Contributor Author

commented Jan 25, 2019

Done! Thank you

@collin5

This comment has been minimized.

Copy link
Contributor Author

commented Apr 9, 2019

@chris-crone
Copy link
Contributor

left a comment

LGTM, thanks @collin5!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.