Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pickup and use eventual HTTP proxy #6559

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@joakimr-axis
Copy link

joakimr-axis commented Mar 8, 2019

Without passing proper proxy settings to the docker build command, it
will fail. This patch mitigates that (and works if no proxy is set).

Change-Id: I81e50b173047dd4a92b5a38a4940eff3453c8b80
Signed-off-by: Joakim Roubert joakimr@axis.com

Resolves #2590

@joakimr-axis

This comment has been minimized.

Copy link
Author

joakimr-axis commented Mar 8, 2019

How should I interpret this output from Jenkins?

10:33:49 b6da999fed9c: Retrying in 2 seconds
10:33:50 b6da999fed9c: Retrying in 1 second
10:33:59 efa807d0493e: Pushed
10:33:59 received unexpected HTTP status: 500 Internal Server Error
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // wrap
[Pipeline] }
[Pipeline] // wrap
[Pipeline] }
[Pipeline] // withDockerRegistry
[Pipeline] }
[Pipeline] // node
[Pipeline] End of Pipeline

GitHub has been notified of this commit’s build result

ERROR: script returned exit code 1
Finished: FAILURE

Internal error, why? Something I can do about it, and if so, how?

@ijc

This comment has been minimized.

Copy link
Contributor

ijc commented Mar 8, 2019

The 500 is an external issue, the appropriate people have been paged.

Sorry for the inconvenience.

@GordonTheTurtle

This comment has been minimized.

Copy link

GordonTheTurtle commented Mar 11, 2019

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "httpproxy" git@github.com:joakimr-axis/compose.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842357815536
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@joakimr-axis joakimr-axis changed the title script/test/default: Pickup and use eventual HTTP proxy Pickup and use eventual HTTP proxy Mar 11, 2019

@joakimr-axis joakimr-axis force-pushed the joakimr-axis:httpproxy branch from 2ccbdcb to d26de19 Mar 11, 2019

@GordonTheTurtle GordonTheTurtle removed the dco/no label Mar 11, 2019

Pickup and use eventual HTTP proxy in scripts
Without passing proper proxy settings to docker, it will fail in
a proxy environment. This patch mitigates that (and works if no
proxy is set).

Change-Id: I81e50b173047dd4a92b5a38a4940eff3453c8b80
Signed-off-by: Joakim Roubert <joakimr@axis.com>

@joakimr-axis joakimr-axis force-pushed the joakimr-axis:httpproxy branch from d26de19 to f0ce68a Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.