Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile: Decrease footprint by using python-slim-stretch #6568

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@joakimr-axis
Copy link

joakimr-axis commented Mar 8, 2019

The Docker image for docker-compose is HUGE. By using the slim version
of the Debian python base image, footprint is still huge, but
significantly decreased as compared to before.

Change-Id: If62e87ee05975cb734aa6b7252c935e37fc8938c
Signed-off-by: Joakim Roubert joakimr@axis.com

Resolves #6567

@GordonTheTurtle

This comment has been minimized.

Copy link

GordonTheTurtle commented Mar 8, 2019

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "useslim" git@github.com:joakimr-axis/compose.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842357578848
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@joakimr-axis

This comment has been minimized.

Copy link
Author

joakimr-axis commented Mar 8, 2019

How should I interpret the jenkins failure:

13:57:17 c091a343e78c: Retrying in 1 second
13:57:21 c091a343e78c: Pushed
13:57:24 6d35c210d68a: Pushed
13:57:28 received unexpected HTTP status: 500 Internal Server Error
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // wrap
[Pipeline] }
[Pipeline] // wrap
[Pipeline] }
[Pipeline] // withDockerRegistry
[Pipeline] }
[Pipeline] // node
[Pipeline] End of Pipeline
Terminated

GitHub has been notified of this commit’s build result

ERROR: script returned exit code 1
Finished: FAILURE

Internal error, but why? And can I retrigger?

@joakimr-axis

This comment has been minimized.

Copy link
Author

joakimr-axis commented Mar 11, 2019

This pull request is superfluous if #6577 is merged.

@joakimr-axis joakimr-axis force-pushed the joakimr-axis:useslim branch from 2816094 to 97db0cb Mar 12, 2019

@GordonTheTurtle GordonTheTurtle removed the dco/no label Mar 12, 2019

@joakimr-axis joakimr-axis force-pushed the joakimr-axis:useslim branch from 97db0cb to 4769614 Mar 15, 2019

@joakimr-axis joakimr-axis changed the title Dockerfile: Decrease footprint by using python-slim Dockerfile: Decrease footprint by using python-alpine Mar 15, 2019

@joakimr-axis

This comment has been minimized.

Copy link
Author

joakimr-axis commented Mar 15, 2019

Using alpine instead of stretch slim decreases footprint even more.

@joakimr-axis joakimr-axis force-pushed the joakimr-axis:useslim branch 2 times, most recently from 8a4e3d7 to f58be52 Mar 15, 2019

Dockerfile: Decrease footprint by using slim-stretch
The Docker image for docker-compose is HUGE. By using slim-stretch,
footprint is significantly decreased as compared to before.

Change-Id: If62e87ee05975cb734aa6b7252c935e37fc8938c
Signed-off-by: Joakim Roubert <joakimr@axis.com>

@joakimr-axis joakimr-axis force-pushed the joakimr-axis:useslim branch from f58be52 to 2a4c2c1 Mar 16, 2019

@joakimr-axis joakimr-axis changed the title Dockerfile: Decrease footprint by using python-alpine Dockerfile: Decrease footprint by using python-slim-stretch Mar 16, 2019

@ulyssessouza

This comment has been minimized.

Copy link
Collaborator

ulyssessouza commented Apr 19, 2019

Closing this in favor of #6641

@joakimr-axis joakimr-axis deleted the joakimr-axis:useslim branch Apr 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.