Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make test scripts POSIX compatible #6574

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@joakimr-axis
Copy link

joakimr-axis commented Mar 11, 2019

Change-Id: I69e412d86381f22287abb963295e2aab6c791ee4
Signed-off-by: Joakim Roubert joakimr@axis.com

Resolves #6573

Show resolved Hide resolved script/test/all Outdated

@joakimr-axis joakimr-axis force-pushed the joakimr-axis:testscriptupdates branch from 7035098 to d00ac38 Mar 12, 2019

@GordonTheTurtle

This comment has been minimized.

Copy link

GordonTheTurtle commented Mar 12, 2019

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "testscriptupdates" git@github.com:joakimr-axis/compose.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842358448992
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@joakimr-axis joakimr-axis force-pushed the joakimr-axis:testscriptupdates branch from d4a3401 to b89fe95 Mar 12, 2019

@GordonTheTurtle GordonTheTurtle removed the dco/no label Mar 12, 2019

Make test scripts POSIX compatible
Change-Id: I69e412d86381f22287abb963295e2aab6c791ee4
Signed-off-by: Joakim Roubert <joakimr@axis.com>

@joakimr-axis joakimr-axis force-pushed the joakimr-axis:testscriptupdates branch from b89fe95 to 9c32679 Mar 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.