Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make build scripts POSIX compatible #6576

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@joakimr-axis
Copy link

joakimr-axis commented Mar 11, 2019

Change-Id: Ib74ab851c869c76720f5d0460de2522a00212170
Signed-off-by: Joakim Roubert joakimr@axis.com

Resolves #6575

Show resolved Hide resolved script/build/image Outdated
Make build scripts POSIX compatible
Change-Id: Ib74ab851c869c76720f5d0460de2522a00212170
Signed-off-by: Joakim Roubert <joakimr@axis.com>

@joakimr-axis joakimr-axis force-pushed the joakimr-axis:buildscriptupdates branch from a7f680e to 629274a Mar 12, 2019

@GordonTheTurtle

This comment has been minimized.

Copy link

GordonTheTurtle commented Apr 23, 2019

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "buildscriptupdates" git@github.com:joakimr-axis/compose.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842358451872
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@joakimr-axis joakimr-axis force-pushed the joakimr-axis:buildscriptupdates branch from b96a1d4 to 629274a Apr 23, 2019

@GordonTheTurtle GordonTheTurtle removed the dco/no label Apr 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.