Fix some typos #374

Merged
merged 1 commit into from Dec 16, 2016

Projects

None yet

6 participants

@hqhq
Contributor
hqhq commented Dec 15, 2016

Signed-off-by: Qiang Huang h.huangqiang@huawei.com

@estesp

except for one change, all are proper corrections

@@ -45,7 +45,7 @@ interface.
## Architecture
The _Snapshot Manager_ provides an API for allocating, snapshotting and mounting
-abstract, layer-based filesytems. The model works by building up sets of
@estesp
estesp Dec 15, 2016 Member

The plural is actually more correct here: "An API for mounting filesystems." vs. "An API for mounting filesystem."

@AkihiroSuda
AkihiroSuda Dec 15, 2016 Contributor

filesytems -> filesystems

@hqhq
hqhq Dec 16, 2016 Contributor

Ha, when misspell told me:
design/snapshots.md:48:22: "filesytems" is a misspelling of "filesystem", I thought it's talking about plural issue :P , fixed.

@@ -11,7 +11,7 @@ import (
)
// Manager provides an API for allocating, snapshotting and mounting
-// abstract, layer-based filesytems. The model works by building up sets of
@estesp
estesp Dec 15, 2016 Member

Same as the note in the .md file; plural is correct.

@stevvooe
stevvooe Dec 15, 2016 Contributor

It looks like someone copy-pasted this. Sloppy. 🤔

@AkihiroSuda
Contributor

You may want to s/containerD/containerd/g as well?
https://github.com/docker/containerd/blob/master/design/mounts.md

@AkihiroSuda
Contributor

Also you may want to back-quote some function name strings
https://github.com/docker/containerd/blob/master/design/snapshots.md

@stevvooe
Contributor

Thanks for the look, @hqhq!

@hqhq hqhq Fix some typos
Signed-off-by: Qiang Huang <h.huangqiang@huawei.com>
3b8eee7
@hqhq
Contributor
hqhq commented Dec 16, 2016

@AkihiroSuda I'm not sure about containerD issue, what's the way we prefer?
I haven't look through https://github.com/docker/containerd/blob/master/design/snapshots.md , maybe we can do that in a separate PR, thanks for your tips :)

@AkihiroSuda
Contributor

Looking at 25b14eb (cc @icecrime ), the project name seems "containerd", not "containerD" nor "Containerd". But it is ok to have that fix in a separate PR 😄

@hqhq
Contributor
hqhq commented Dec 16, 2016

@AkihiroSuda Thanks, updated.

@estesp
estesp approved these changes Dec 16, 2016 View changes
@estesp
Member
estesp commented Dec 16, 2016

LGTM

@icecrime
Member

Correct @AkihiroSuda 😉 The project name should be containerd lowercase everywhere (we probably need an FAQ for that).

@crosbymichael
Member

LGTM

@crosbymichael crosbymichael merged commit 3cdf1d8 into docker:master Dec 16, 2016

1 check passed

dco-signed All commits are signed
@hqhq hqhq deleted the hqhq:fix_typos branch Dec 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment