cmd/containerd: extend to other OCI runtimes #382

Merged
merged 1 commit into from Jan 10, 2017

Projects

None yet

4 participants

@runcom
Member
runcom commented Dec 15, 2016

Signed-off-by: Antonio Murdaca runcom@redhat.com

@@ -55,7 +55,7 @@ high performance container runtime
},
cli.StringFlag{
Name: "runtime",
- Usage: "default runtime for execution",
+ Usage: "runtime for execution",
@crosbymichael
crosbymichael Dec 15, 2016 Member

where is this flag used now?

@runcom
runcom Dec 16, 2016 Member

I believe the issue is that it's always hardcoded to use runc

@runcom
runcom Dec 16, 2016 Member

updated

@AkihiroSuda
Contributor

linking crosbymichael/go-runc#2 ("runc.go: support non-default path for the runc command") to this PR, maybe you are interested in

@runcom
Member
runcom commented Dec 16, 2016

linking crosbymichael/go-runc#2 ("runc.go: support non-default path for the runc command") to this PR, maybe you are interested in

we need something passed via flag see #384 also

@runcom runcom cmd/containerd: extend to other OCI runtimes
Signed-off-by: Antonio Murdaca <runcom@redhat.com>
98b3900
@crosbymichael
Member

Just for some back story why we have this flag before we go changing things is that we wanted a way to allow users to use only runc or any oci runtime or use "the shim" so that things like live restore are supported.

Most will want the shim but not everyone so I added this flag.

@runcom
Member
runcom commented Dec 16, 2016

So according to #384 would be nice to leave this flag so people can use any oci runtime. Is my understanding wrong?

@runcom
Member
runcom commented Dec 16, 2016

Of course, I mean just for texting, I got ctr isn't on the road map (there's Docker already I believe) but still, an easy way for people to test out runtime would be nice to have (and doesn't require containerd changes as long as runtimes follow some spec)

@hqhq
Contributor
hqhq commented Dec 20, 2016

LGTM

@crosbymichael
Member

LGTM

@crosbymichael crosbymichael merged commit 4c848c4 into docker:master Jan 10, 2017

1 check passed

dco-signed All commits are signed
@runcom runcom deleted the runcom:not-only-runc branch Jan 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment