New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.7.0 violates semver #2799

Closed
docwhat opened this Issue Jan 4, 2019 · 4 comments

Comments

Projects
None yet
5 participants
@docwhat
Copy link

docwhat commented Jan 4, 2019

Due to change #2711 (commit aa985ba), 2.7.0 breaks existing 2.x installations.

This violates semantic versioning.

We should either:

  1. Set a default value that behaves as before; I think that the value of false is the old 2.6 behavior.
  2. Release version 3.0.0 and strike 2.7.0 as a "bad version".
@mjburling

This comment has been minimized.

Copy link

mjburling commented Jan 4, 2019

Ran into this last night. Any clue when this hit Dockerhub? Shame on me for not pinning the minor version in the first place.

@docwhat

This comment has been minimized.

Copy link

docwhat commented Jan 4, 2019

I think it did yesterday. Maybe around 6pm EDT EST?

@caervs

This comment has been minimized.

Copy link
Collaborator

caervs commented Jan 4, 2019

I think it did yesterday. Maybe around 6pm EDT?

@docwhat That is correct.

@davidswu has put out #2800 to default to false (preserving old behavior) which we should be able to put out in 2.7.1. Stay tuned for the release schedule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment