New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

registry/handlers: ignore notfound on storage driver healthcheck #2377

Merged
merged 1 commit into from Sep 29, 2017

Conversation

Projects
None yet
4 participants
@stevvooe
Contributor

stevvooe commented Aug 21, 2017

Signed-off-by: Stephen J Day stephen.day@docker.com

I think this is the right fix. It would be great if someone could give this a try. Let me know if you need instructions.

cc @dumyan @liclac @deterralba @beniwtv @pollosp @oms

Closes #2292

registry/handlers: ignore notfound on storage driver healthcheck
Signed-off-by: Stephen J Day <stephen.day@docker.com>
@codecov

This comment has been minimized.

codecov bot commented Aug 21, 2017

Codecov Report

Merging #2377 into master will decrease coverage by 9.59%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #2377     +/-   ##
=========================================
- Coverage   60.24%   50.65%   -9.6%     
=========================================
  Files         126      126             
  Lines       14426    14428      +2     
=========================================
- Hits         8691     7308   -1383     
- Misses       4847     6372   +1525     
+ Partials      888      748    -140
Impacted Files Coverage Δ
registry/handlers/app.go 48.3% <0%> (-0.14%) ⬇️
registry/storage/driver/gcs/gcs.go 0.32% <0%> (-66.13%) ⬇️
registry/storage/driver/oss/oss.go 0.45% <0%> (-56.5%) ⬇️
registry/storage/driver/s3-aws/s3.go 4.07% <0%> (-55.4%) ⬇️
registry/storage/driver/s3-goamz/s3.go 0.4% <0%> (-52.4%) ⬇️
registry/client/transport/transport.go 68.75% <0%> (-8.75%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f6282d...1618b49. Read the comment docs.

@liclac

This comment has been minimized.

liclac commented Aug 22, 2017

👍

@oms

This comment has been minimized.

oms commented Aug 30, 2017

Fix seems good in my testing. 👍

@stevvooe

This comment has been minimized.

Contributor

stevvooe commented Aug 30, 2017

@dmcgowan PTAL

@dmcgowan

This comment has been minimized.

Member

dmcgowan commented Sep 29, 2017

LGTM

@dmcgowan dmcgowan merged commit 8710fa5 into docker:master Sep 29, 2017

3 of 5 checks passed

codecov/patch 0% of diff hit (target 60.24%)
Details
codecov/project 50.65% (-9.6%) compared to 5f6282d
Details
ci/circleci Your tests passed on CircleCI!
Details
dco-signed All commits are signed
janky Jenkins build Distribution-PRs 1951 has succeeded
Details

@stevvooe stevvooe deleted the stevvooe:healthcheck-storage-ignore-notfound branch Sep 29, 2017

fancyremarker added a commit to fancyremarker/docker-registry-all-in-one that referenced this pull request Oct 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment