New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo #2734

Merged
merged 1 commit into from Oct 24, 2018

Conversation

Projects
None yet
5 participants
@mgrachev
Contributor

mgrachev commented Oct 14, 2018

No description provided.

@GordonTheTurtle

This comment has been minimized.

GordonTheTurtle commented Oct 14, 2018

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "patch-1" git@github.com:mgrachev/distribution.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@dmcgowan

This comment has been minimized.

Member

dmcgowan commented Oct 17, 2018

Please sign the commit, all commits must be signed to get CI to pass

Fix typo
Signed-off-by: Mikhail Grachev <work@mgrachev.com>

@GordonTheTurtle GordonTheTurtle removed the dco/no label Oct 18, 2018

@mgrachev

This comment has been minimized.

Contributor

mgrachev commented Oct 18, 2018

@dmcgowan Done.

@codecov

This comment has been minimized.

codecov bot commented Oct 18, 2018

Codecov Report

Merging #2734 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2734   +/-   ##
=======================================
  Coverage   60.28%   60.28%           
=======================================
  Files         103      103           
  Lines        8003     8003           
=======================================
  Hits         4825     4825           
  Misses       2536     2536           
  Partials      642      642
Flag Coverage Δ
#linux 60.28% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cb4180...cd1648d. Read the comment docs.

@dmp42

dmp42 approved these changes Oct 24, 2018

@dmp42 dmp42 merged commit 93e0827 into docker:master Oct 24, 2018

4 checks passed

codecov/patch Coverage not affected when comparing 1cb4180...cd1648d
Details
codecov/project 60.28% remains the same compared to 1cb4180
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
dco-signed All commits are signed

@mgrachev mgrachev deleted the mgrachev:patch-1 branch Oct 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment