New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "--userns host" to `docker run` example #268

Merged
merged 1 commit into from Nov 23, 2017

Conversation

Projects
None yet
3 participants
@jhermann
Contributor

jhermann commented Nov 20, 2017

If UID remapping is configured as a default, it has to be defeated for running the benchmark.

@GordonTheTurtle

This comment has been minimized.

Show comment
Hide comment
@GordonTheTurtle

GordonTheTurtle Nov 20, 2017

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "patch-1" git@github.com:jhermann/docker-bench-security.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

GordonTheTurtle commented Nov 20, 2017

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "patch-1" git@github.com:jhermann/docker-bench-security.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Add "--userns host" to docker run example
If UID remapping is configured as a default, it has to be defeated.

Signed-off-by: Juergen Hermann <jh@web.de>

@GordonTheTurtle GordonTheTurtle removed the dco/no label Nov 20, 2017

@konstruktoid

This comment has been minimized.

Show comment
Hide comment
@konstruktoid

konstruktoid Nov 20, 2017

Member

Thanks for the PR @jhermann, but what do you mean by it has to be defeated for running the benchmark.

Member

konstruktoid commented Nov 20, 2017

Thanks for the PR @jhermann, but what do you mean by it has to be defeated for running the benchmark.

@jhermann

This comment has been minimized.

Show comment
Hide comment
@jhermann

jhermann Nov 21, 2017

Contributor

Because you get this otherwise, with the current command line:

docker: Error response from daemon: cannot share the host's network namespace when user namespaces are enabled.

Add the additional option, and it works on machines where user namespaces are not set to the default.

Contributor

jhermann commented Nov 21, 2017

Because you get this otherwise, with the current command line:

docker: Error response from daemon: cannot share the host's network namespace when user namespaces are enabled.

Add the additional option, and it works on machines where user namespaces are not set to the default.

@konstruktoid konstruktoid merged commit 3633545 into docker:master Nov 23, 2017

1 check passed

dco-signed All commits are signed
@konstruktoid

This comment has been minimized.

Show comment
Hide comment
@konstruktoid

konstruktoid Nov 23, 2017

Member

Thanks, I just wasn't sure about the wording.

Member

konstruktoid commented Nov 23, 2017

Thanks, I just wasn't sure about the wording.

@konstruktoid

This comment has been minimized.

Show comment
Hide comment
@konstruktoid

konstruktoid Nov 23, 2017

Member

Thanks, I just wasn't sure of the wording.

Member

konstruktoid commented Nov 23, 2017

Thanks, I just wasn't sure of the wording.

@jhermann jhermann deleted the jhermann:patch-1 branch Nov 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment