New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to the HTTPS alpine apk repositories #271

Merged
merged 1 commit into from Dec 6, 2017

Conversation

Projects
None yet
5 participants
@tpartington

tpartington commented Dec 6, 2017

The alpine docker image uses HTTP endpoints for the apk repositories by default.
There is an open issue to enable support for HTTPS endpoints with a work-around provided.

This change implements the work-around, replacing the HTTP endpoints with the HTTPS endpoints in the /etc/apk/repositories file.

@GordonTheTurtle

This comment has been minimized.

Show comment
Hide comment
@GordonTheTurtle

GordonTheTurtle Dec 6, 2017

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "alpine-https-repositories" git@github.com:tpartington/docker-bench-security.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

GordonTheTurtle commented Dec 6, 2017

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "alpine-https-repositories" git@github.com:tpartington/docker-bench-security.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Tom Partington
Switch to the HTTPS endpoint for the alpine APK repositories
Signed-off-by: Tom Partington <tom.partington@cevo.com.au>

@GordonTheTurtle GordonTheTurtle removed the dco/no label Dec 6, 2017

@konstruktoid

This comment has been minimized.

Show comment
Hide comment
@konstruktoid

konstruktoid Dec 6, 2017

Member

Thanks @tpartington, nice catch and thank you for the PR.

Member

konstruktoid commented Dec 6, 2017

Thanks @tpartington, nice catch and thank you for the PR.

@konstruktoid konstruktoid merged commit d05852c into docker:master Dec 6, 2017

1 check passed

dco-signed All commits are signed
@introllo

This comment has been minimized.

Show comment
Hide comment
@introllo

introllo Mar 2, 2018

Has anyone gotten this working (via HTTPS) behind a proxy? for me, when behind my proxy, any apk update fails. NOTE: using --build-arg http_proxy=http://proxy.server.com --build-arg https_proxy=http://secure-proxy.server.com in my build step.

introllo commented Mar 2, 2018

Has anyone gotten this working (via HTTPS) behind a proxy? for me, when behind my proxy, any apk update fails. NOTE: using --build-arg http_proxy=http://proxy.server.com --build-arg https_proxy=http://secure-proxy.server.com in my build step.

@denji

This comment has been minimized.

Show comment
Hide comment
@denji

denji May 7, 2018

  • RUN sed -i 's#http://dl-cdn.alpinelinux.org#https://alpine.global.ssl.fastly.net#g' /etc/apk/repositories
  • RUN sed -i 's@http://dl-cdn.alpinelinux.org@https://alpine.global.ssl.fastly.net@g' /etc/apk/repositories

denji commented May 7, 2018

  • RUN sed -i 's#http://dl-cdn.alpinelinux.org#https://alpine.global.ssl.fastly.net#g' /etc/apk/repositories
  • RUN sed -i 's@http://dl-cdn.alpinelinux.org@https://alpine.global.ssl.fastly.net@g' /etc/apk/repositories
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment