Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mount volumes read only #385

Merged
merged 1 commit into from Aug 29, 2019

Conversation

@J0WI
Copy link
Contributor

commented Jun 28, 2019

No description provided.

@konstruktoid

This comment has been minimized.

Copy link
Member

commented Jul 1, 2019

Thanks for the PR @J0WI, I'll have a look at it later on.

@konstruktoid

This comment has been minimized.

Copy link
Member

commented Aug 29, 2019

@GordonTheTurtle

This comment has been minimized.

Copy link

commented Aug 29, 2019

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "ro" git@github.com:J0WI/docker-bench-security.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842357816184
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Mount volumes read only
Signed-off-by: J0WI <J0WI@users.noreply.github.com>

@J0WI J0WI force-pushed the J0WI:ro branch from 58436f4 to 59c289e Aug 29, 2019

@GordonTheTurtle GordonTheTurtle removed the dco/no label Aug 29, 2019

@konstruktoid

This comment has been minimized.

Copy link
Member

commented Aug 29, 2019

Thanks!

@konstruktoid konstruktoid merged commit b354514 into docker:master Aug 29, 2019

1 check passed

dco-signed All commits are signed

@J0WI J0WI deleted the J0WI:ro branch Aug 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.