Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Raspbian buster #349

Merged
merged 2 commits into from Jun 26, 2019

Conversation

@ndanyluk
Copy link
Contributor

commented Jun 25, 2019

This PR adds a docker file for raspbian buster and modifies the makefile to include it. I followed the same format in the makefile as was used for raspbian-stretch and debian-buster

@thaJeztah

This comment has been minimized.

Copy link
Member

commented Jun 25, 2019

thanks! will have to give this a look, but could you squash the first two commits? (second one looks like it's fixing up a thing from the first one)

let me know if you need help doing so

@thaJeztah

This comment has been minimized.

Copy link
Member

commented Jun 25, 2019

also: @seemethere @zelahi PTAL

@seemethere
Copy link
Member

left a comment

Overall looks good to me but I do agree with @thaJeztah’s request to squash the first two commits

@ndanyluk ndanyluk force-pushed the ndanyluk:add-raspbian-buster branch from 2e6de3e to e6445e3 Jun 26, 2019

@ndanyluk

This comment has been minimized.

Copy link
Contributor Author

commented Jun 26, 2019

Ok I think I got the commits squashed properly. I've never done that before, but I think it worked. Please let me know if there's any other changes you want me to make and I'd be happy to help! @thaJeztah @seemethere

@seemethere seemethere merged commit 07dd514 into docker:master Jun 26, 2019

1 of 2 checks passed

unir Automatic merge is pending, 1 more approval(s) needed
continuous-integration/jenkins/pr-head This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.