New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds packaging for Fedora 27 #59

Merged
merged 1 commit into from Nov 21, 2017

Conversation

Projects
None yet
4 participants
@seemethere
Contributor

seemethere commented Nov 14, 2017

Fedora 27 has hit GA! https://fedoramagazine.org/announcing-fedora-27/

Relies on: docker-library/official-images#3708

Relates to:

NOTE: The next release this is eligible for is 17.12.0-ce

Signed-off-by: Eli Uriegas eli.uriegas@docker.com

Adds packaging for Fedora 27
Signed-off-by: Eli Uriegas <eli.uriegas@docker.com>

@seemethere seemethere requested review from andrewhsu, friism and thaJeztah Nov 14, 2017

@@ -0,0 +1,17 @@
FROM fedora:27
RUN dnf -y upgrade
RUN dnf install -y @development-tools fedora-packager

This comment has been minimized.

@thaJeztah

thaJeztah Nov 14, 2017

Member

Should we follow best-practice here, and combine dnf -y upgrade with the dnf install lines? (I guess we don't use caching, so probably doesn't make a big difference)

@thaJeztah

thaJeztah Nov 14, 2017

Member

Should we follow best-practice here, and combine dnf -y upgrade with the dnf install lines? (I guess we don't use caching, so probably doesn't make a big difference)

This comment has been minimized.

@seemethere

seemethere Nov 14, 2017

Contributor

Yeah these aren't cached when we build packages since we build on freshly spawned slaves in the Jenkins setup, WDYT @andrewhsu?

@seemethere

seemethere Nov 14, 2017

Contributor

Yeah these aren't cached when we build packages since we build on freshly spawned slaves in the Jenkins setup, WDYT @andrewhsu?

This comment has been minimized.

@thaJeztah

thaJeztah Nov 14, 2017

Member

It's just a nit, definitely no blocker for this PR

@thaJeztah

thaJeztah Nov 14, 2017

Member

It's just a nit, definitely no blocker for this PR

@thaJeztah

LGTM assuming the builds work 😜

@seemethere

This comment has been minimized.

Show comment
Hide comment
@seemethere

seemethere Nov 14, 2017

Contributor

Can confirm I was able to successfully build packages after the merge of docker-library/official-images#3708

Contributor

seemethere commented Nov 14, 2017

Can confirm I was able to successfully build packages after the merge of docker-library/official-images#3708

@trapier

This comment has been minimized.

Show comment
Hide comment
@trapier

trapier Nov 15, 2017

Please also PR the docs when this is available. Would do it myself, but I don't know if F24 is still supported (and thus might need to be removed).

trapier commented Nov 15, 2017

Please also PR the docs when this is available. Would do it myself, but I don't know if F24 is still supported (and thus might need to be removed).

@ogajduse

This comment has been minimized.

Show comment
Hide comment
@ogajduse

ogajduse Nov 18, 2017

@trapier Fedora 24 hit the EOL on August 8th, 2017.

ogajduse commented Nov 18, 2017

@trapier Fedora 24 hit the EOL on August 8th, 2017.

@seemethere seemethere merged commit 3519a35 into docker:master Nov 21, 2017

@seemethere seemethere deleted the seemethere:add_f27 branch Nov 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment