New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defaults Makefile VERSION variable to 0.0.0-dev #67

Merged
merged 1 commit into from Dec 7, 2017

Conversation

Projects
None yet
3 participants
@seemethere
Contributor

seemethere commented Dec 7, 2017

When building we should default to a dummy version unless otherwise
specified so we don't get ourselves confused over what is official and
what is not.

Relates to: moby/moby#35368

Thanks to @glasser for first discovering this!

Signed-off-by: Eli Uriegas eli.uriegas@docker.com

@seemethere seemethere requested a review from andrewhsu Dec 7, 2017

Defaults Makefile VERSION variable to 0.0.0-dev
When building we should default to a dummy version unless otherwise
specified so we don't get ourselves confused over what is official and
what is not.

Signed-off-by: Eli Uriegas <eli.uriegas@docker.com>

@seemethere seemethere requested review from corbin-coleman and jose-bigio Dec 7, 2017

@glasser

This comment has been minimized.

Show comment
Hide comment
@glasser

glasser Dec 7, 2017

We build our own fork of Docker CE and try to stick to the official released tags, so it's nice to be able to get the actual v17.09-dev version (augmented with our git commit), so this PR doesn't help us.

Of course we can just specify VERSION explicitly when we do so, but it would be nice if we didn't have to :)

By the way, thank you so much for the work in this repo. We are finally upgrading from v1.11 and make ubuntu-xenial is so so so so much easier than the old method. It's nice to not have to run scripts with hack in their name :)

glasser commented Dec 7, 2017

We build our own fork of Docker CE and try to stick to the official released tags, so it's nice to be able to get the actual v17.09-dev version (augmented with our git commit), so this PR doesn't help us.

Of course we can just specify VERSION explicitly when we do so, but it would be nice if we didn't have to :)

By the way, thank you so much for the work in this repo. We are finally upgrading from v1.11 and make ubuntu-xenial is so so so so much easier than the old method. It's nice to not have to run scripts with hack in their name :)

@jose-bigio

LGTM

@seemethere seemethere merged commit ffcd040 into docker:master Dec 7, 2017

1 check passed

continuous-integration/jenkins/pr-head This commit looks good
Details

@seemethere seemethere deleted the seemethere:fix_makefile_versioning branch Dec 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment