New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.06][engine][vendor] forks of containerd + runc + runtime-spec #102

Merged
merged 1 commit into from Jul 12, 2017

Conversation

Projects
None yet
2 participants
@tiborvass
Contributor

tiborvass commented Jul 7, 2017

This vendors from the docker github org:

This fixes two issues:

  • if the container is paused, it now responds properly to SIGKILL
  • on buggy kernels such as RHEL7.2, a int64->uint64 conversion bug prevented containers to start when memory cgroup was specified.

Signed-off-by: Tibor Vass tibor@docker.com

@andrewhsu andrewhsu changed the title from [WIP] Runtime spec fix to [17.06] Runtime spec fix Jul 12, 2017

@andrewhsu

This comment has been minimized.

Show comment
Hide comment
@andrewhsu

andrewhsu Jul 12, 2017

Collaborator

Builds are green with 823b9ec

Collaborator

andrewhsu commented Jul 12, 2017

Builds are green with 823b9ec

[engine][vendor] forks of containerd + runc + runtime-spec
This vendors from the docker org:
- containerd to 6e23458c129b551d5c9871e5174f6b1b7f6d1170
- runc to 810190ceaa507aa2727d7ae6f4790c76ec150bd2
- runtime-spec to a45ba0989fc26c695fe166a49c45bb8b7618ab36

This fixes two issues:
- if the container is paused, it now responds properly to SIGKILL
- on buggy kernels such as RHEL7.2, a int64->uint64 conversion bug
  prevented containers to start when memory cgroup was specified.

Signed-off-by: Tibor Vass <tibor@docker.com>

@tiborvass tiborvass changed the title from [17.06] Runtime spec fix to [17.06][engine][vendor] forks of containerd + runc + runtime-spec Jul 12, 2017

@andrewhsu andrewhsu modified the milestone: 17.06.1 Jul 12, 2017

@andrewhsu

This comment has been minimized.

Show comment
Hide comment
@andrewhsu

andrewhsu Jul 12, 2017

Collaborator

LGTM

Stuff works on RHEL7.2

@crosbymichael if you get the chance, can you also have a look?

Collaborator

andrewhsu commented Jul 12, 2017

LGTM

Stuff works on RHEL7.2

@crosbymichael if you get the chance, can you also have a look?

@andrewhsu andrewhsu merged commit 136b90f into docker:17.06 Jul 12, 2017

3 checks passed

ce-tests Jenkins build docker-ce-17.06-pr 173 has succeeded
Details
ce-tests-WoW-RS1 Jenkins build docker-ce-17.06-pr-WoW-RS1 165 has succeeded
Details
dco-signed All commits are signed

docker-jenkins pushed a commit that referenced this pull request Apr 10, 2018

Merge pull request #102 from seemethere/arm64_buster
Add aarch64 builder for debian-buster
Upstream-commit: 54456bf1ef88a6698744e035d3655c8bcfd8e410
Component: packaging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment