New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.06] Docker wait hangs indefinitely for non-existent container (vendor) #106

Merged
merged 1 commit into from Jul 12, 2017

Conversation

Projects
None yet
3 participants
@andrewhsu
Collaborator

andrewhsu commented Jul 11, 2017

Backport fix:

Into components/cli/vendor/github.com/docker/docker with cherry-pick moby/moby@4d2d2ea:

$ git cherry-pick -s -x -Xsubtree=components/cli/vendor/github.com/docker/docker 4d2d2ea

This fix was already included in 1dc2936 to components/engine, but is also needed in components/cli/vendor.

@thaJeztah

LGTM

Remove deadlock in ContainerWait
when `cli.post(...)` fails `errC <- err` blocks because `errC` is unbufferd.

Signed-off-by: Simon Menke <simon.menke@gmail.com>
(cherry picked from commit 4d2d2ea)
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>

@andrewhsu andrewhsu merged commit 068a428 into docker:17.06 Jul 12, 2017

3 checks passed

ce-tests Jenkins build docker-ce-17.06-pr 166 has succeeded
Details
ce-tests-WoW-RS1 Jenkins build docker-ce-17.06-pr-WoW-RS1 162 has succeeded
Details
dco-signed All commits are signed

@andrewhsu andrewhsu deleted the andrewhsu:fix-wait-hang branch Jul 12, 2017

@andrewhsu andrewhsu modified the milestone: 17.06.1 Jul 12, 2017

docker-jenkins pushed a commit that referenced this pull request May 18, 2018

Merge pull request #106 from seemethere/remove_f26
Remove Fedora 26
Upstream-commit: 4fc747eac9a6828ec94094dac442ba3f72192251
Component: packaging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment