New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.06] vndr check engine #112

Merged
merged 2 commits into from Jul 11, 2017

Conversation

Projects
None yet
2 participants
@andrewhsu
Collaborator

andrewhsu commented Jul 11, 2017

Vendored code mismatch from vendor.conf. Looks like github.com/Microsoft/go-winio was missing some changes and github.com/spf13/cobra is no longer needed.

andrewhsu added some commits Jul 11, 2017

vndr to update vendor for github.com/Microsoft/go-winio
No changes to vendor.conf, just running vndr.

Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
vndr to update vendor for github.com/spf13/cobra
No changes to vendor.conf, just running vndr.

Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
@thaJeztah

LGTM

@andrewhsu

This comment has been minimized.

Show comment
Hide comment
@andrewhsu

andrewhsu Jul 11, 2017

Collaborator

@mlaventure fyi looks like the jump from Microsoft/go-winio v0.4.0 to v0.4.2 in PR #3 missed this change: af26684

Collaborator

andrewhsu commented Jul 11, 2017

@mlaventure fyi looks like the jump from Microsoft/go-winio v0.4.0 to v0.4.2 in PR #3 missed this change: af26684

@andrewhsu

This comment has been minimized.

Show comment
Hide comment
@andrewhsu

andrewhsu Jul 11, 2017

Collaborator

@johnstep hmm...the windows tests pass. is this PR related to the good sign?

Collaborator

andrewhsu commented Jul 11, 2017

@johnstep hmm...the windows tests pass. is this PR related to the good sign?

@andrewhsu andrewhsu merged commit 2036e34 into docker:17.06 Jul 11, 2017

3 checks passed

ce-tests Jenkins build docker-ce-17.06-pr 160 has succeeded
Details
ce-tests-WoW-RS1 Jenkins build docker-ce-17.06-pr-WoW-RS1 151 has succeeded
Details
dco-signed All commits are signed

@andrewhsu andrewhsu deleted the andrewhsu:re-vndr-engine branch Jul 11, 2017

@andrewhsu andrewhsu modified the milestone: 17.06.1 Jul 12, 2017

docker-jenkins pushed a commit that referenced this pull request Jun 1, 2018

Merge pull request #112 from seemethere/progs
btrfs-tools -> btrfs-progs
Upstream-commit: 7df78c90c9ff96e853f5cd07f7ba0d9c69a55e87
Component: packaging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment