New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.12] Pass VERSION to engine static builds #347

Merged
merged 1 commit into from Dec 12, 2017

Conversation

Projects
None yet
2 participants
@seemethere
Member

seemethere commented Dec 12, 2017

backport:

VERSION file does not exist anymore for moby/moby so we need to
compensate

Signed-off-by: Eli Uriegas eli.uriegas@docker.com
(cherry picked from commit c411321b8870101c227b03e64930260984c862fd)
Signed-off-by: Eli Uriegas eli.uriegas@docker.com

Pass VERSION to engine static builds
VERSION file does not exist anymore for moby/moby so we need to
compensate

Signed-off-by: Eli Uriegas <eli.uriegas@docker.com>
(cherry picked from commit c411321b8870101c227b03e64930260984c862fd)
Signed-off-by: Eli Uriegas <eli.uriegas@docker.com>

@seemethere seemethere requested review from andrewhsu and corbin-coleman Dec 12, 2017

@andrewhsu andrewhsu added this to the 17.12.0 milestone Dec 12, 2017

@andrewhsu

LGTM

@andrewhsu andrewhsu merged commit f9cde63 into docker:17.12 Dec 12, 2017

1 of 5 checks passed

ce-tests Jenkins build docker-ce-pr 431 is running
Details
ce-tests-WoW-RS1 Jenkins build docker-ce-pr-WoW-RS1 616 is running
Details
ce-tests-ppc64le Jenkins build docker-ce-pr-ppc64le 212 is running
Details
ce-tests-s390x Jenkins build docker-ce-pr-s390x 222 is running
Details
dco-signed All commits are signed

cpuguy83 pushed a commit to cpuguy83/docker-ce that referenced this pull request Feb 7, 2018

Merge pull request docker#347 from Wolphin-project/stdin
support --compose-file - as stdin
Upstream-commit: 0d17ea257757ad7f7bc2e99d1080f05391bc9967
Component: cli
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment