New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.06] Prevent a goroutine leak when healthcheck gets stopped #90

Merged
merged 1 commit into from Jul 13, 2017

Conversation

Projects
None yet
3 participants
@andrewhsu
Collaborator

andrewhsu commented Jul 4, 2017

Backport fix:

With cherry-pick moby/moby@67297ba:

$ git cherry-pick -s -x -Xsubtree=components/engine 67297ba

No conflicts.

Prevent a goroutine leak when healthcheck gets stopped
Signed-off-by: Kenfe-Mickael Laventure <mickael.laventure@gmail.com>
(cherry picked from commit 67297ba)
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>

@andrewhsu andrewhsu modified the milestone: 17.06.1 Jul 12, 2017

@andrewhsu

This comment has been minimized.

Show comment
Hide comment
@andrewhsu

andrewhsu Jul 13, 2017

Collaborator

🍒 🍴 ? @mlaventure @thaJeztah

Collaborator

andrewhsu commented Jul 13, 2017

🍒 🍴 ? @mlaventure @thaJeztah

@mlaventure

This comment has been minimized.

Show comment
Hide comment
@mlaventure

mlaventure Jul 13, 2017

Contributor

LGTM

Contributor

mlaventure commented Jul 13, 2017

LGTM

@thaJeztah

LGTM

@mlaventure mlaventure merged commit b538302 into docker:17.06 Jul 13, 2017

3 checks passed

ce-tests Jenkins build docker-ce-17.06-pr 161 has succeeded
Details
ce-tests-WoW-RS1 Jenkins build docker-ce-17.06-pr-WoW-RS1 152 has succeeded
Details
dco-signed All commits are signed

@andrewhsu andrewhsu deleted the andrewhsu:fix-leak branch Jul 13, 2017

docker-jenkins pushed a commit that referenced this pull request Mar 8, 2018

Merge pull request #90 from seemethere/fix_dynamic
Use new 'dynamic' args in install.sh
Upstream-commit: 5019e235eb123aba7469b0b91c8b6c1dba3feccf
Component: packaging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment