New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.06] Limit max backoff delay to 2 seconds for GRPC connection #94

Merged
merged 1 commit into from Jul 12, 2017

Conversation

Projects
None yet
4 participants
@andrewhsu
Collaborator

andrewhsu commented Jul 4, 2017

Backport fix:

Limit max backoff delay to 2 seconds for GRPC connection
Docker use default GRPC backoff strategy to reconnect to containerd when
connection is lost. and the delay time grows exponentially, until reaches 120s.

So Change the max delay time to 2s to avoid docker and containerd
connection failure.

Signed-off-by: Wentao Zhang <zhangwentao234@huawei.com>
(cherry picked from commit d3d8c77)
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
@stevvooe

This comment has been minimized.

Show comment
Hide comment
@stevvooe

stevvooe Jul 5, 2017

Contributor

LGTM

Contributor

stevvooe commented Jul 5, 2017

LGTM

@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah Jul 8, 2017

Member

@andrewhsu looks ready to merge

Member

thaJeztah commented Jul 8, 2017

@andrewhsu looks ready to merge

@andrewhsu andrewhsu merged commit 75ef04b into docker:17.06 Jul 12, 2017

3 checks passed

ce-tests Jenkins build docker-ce-17.06-pr 134 has succeeded
Details
ce-tests-WoW-RS1 Jenkins build docker-ce-17.06-pr-WoW-RS1 122 has succeeded
Details
dco-signed All commits are signed

@andrewhsu andrewhsu deleted the andrewhsu:fix-grpc branch Jul 12, 2017

@andrewhsu andrewhsu modified the milestone: 17.06.1 Jul 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment