New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.06] progress: Show progress of replicated tasks before they are assigned #97

Merged
merged 1 commit into from Jul 11, 2017

Conversation

Projects
None yet
3 participants
@andrewhsu
Collaborator

andrewhsu commented Jul 4, 2017

Backport fix:

progress: Show progress of replicated tasks before they are assigned
This was only showing tasks that belong to nodes that are currently up,
so that tasks on down nodes don't appear to be stuck. But this
unintentionally excludes tasks that haven't been assigned yet, so if a
task is stuck before assignment, for example because no nodes meet its
constraints, a progress bar won't even be shown. The check should only
apply to tasks that have a node assignment.

Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
(cherry picked from commit d3d09f67b18673ec457c5f6634d346a937c58728)
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
@thaJeztah

LGTM

ping @aaronlehmann

@aaronlehmann

This comment has been minimized.

Show comment
Hide comment
@aaronlehmann

aaronlehmann Jul 6, 2017

Contributor

LGTM

Contributor

aaronlehmann commented Jul 6, 2017

LGTM

@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah Jul 8, 2017

Member

@andrewhsu looks ready to merge

Member

thaJeztah commented Jul 8, 2017

@andrewhsu looks ready to merge

@andrewhsu andrewhsu merged commit 38f7bac into docker:17.06 Jul 11, 2017

2 of 3 checks passed

ce-tests-WoW-RS1 Jenkins build docker-ce-17.06-pr-WoW-RS1 126 has failed
Details
ce-tests Jenkins build docker-ce-17.06-pr 138 has succeeded
Details
dco-signed All commits are signed

@andrewhsu andrewhsu deleted the andrewhsu:fix-progress branch Jul 11, 2017

@andrewhsu andrewhsu modified the milestone: 17.06.1 Jul 12, 2017

docker-jenkins pushed a commit that referenced this pull request Mar 29, 2018

Merge pull request #97 from seemethere/bionic
Add building code for Ubuntu Bionic (18.04) LTS
Upstream-commit: f2312f5028c946ddeaa89405334ca91a4e5fcb1c
Component: packaging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment