New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow ports to be specified as port/proto #310

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@larsks
Contributor

larsks commented Sep 1, 2014

this patch modifies docker._container_config to accept ports specified as
'port/proto' as well as simply 'port'.

Signed-off-by: Lars Kellogg-Stedman lars@redhat.com

allow ports to be specified as port/proto
this patch modifies docker._container_config to accept ports specified
as 'port/proto' as well as simple 'port'.

Signed-off-by: Lars Kellogg-Stedman <lars@redhat.com>
@shin-

This comment has been minimized.

Show comment
Hide comment
@shin-

shin- Nov 26, 2014

Member

Documentation is clear, I don't see the value in having 10 different ways to specify ports bindings.

Member

shin- commented Nov 26, 2014

Documentation is clear, I don't see the value in having 10 different ways to specify ports bindings.

@shin- shin- closed this Nov 26, 2014

@larsks

This comment has been minimized.

Show comment
Hide comment
@larsks

larsks Nov 27, 2014

Contributor

I don't believe I was proposing ten different ways to specify port bindings. You can decline a patch without being snippy about it.

Contributor

larsks commented Nov 27, 2014

I don't believe I was proposing ten different ways to specify port bindings. You can decline a patch without being snippy about it.

@shin-

This comment has been minimized.

Show comment
Hide comment
@shin-

shin- Nov 27, 2014

Member

Ah, my apologies, I didn't mean to offend, I just wanted to explain my reasoning. Genuinely sorry for the way it came off.

Member

shin- commented Nov 27, 2014

Ah, my apologies, I didn't mean to offend, I just wanted to explain my reasoning. Genuinely sorry for the way it came off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment