From 0258c6e622f41b1c145f28d273424541c354ef6f Mon Sep 17 00:00:00 2001 From: Joffrey F Date: Wed, 21 Oct 2015 13:51:09 -0700 Subject: [PATCH] Update `Client.create_volume` to use new endpoint New API endpoint is POST /volumes/create (previously just /volumes) Since the feature is yet unreleased (RC), no fallback strategy is implemented. Signed-off-by: Joffrey F --- docker/api/volume.py | 2 +- tests/fake_api.py | 2 +- tests/test.py | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/docker/api/volume.py b/docker/api/volume.py index e9e71273f4..a404f658be 100644 --- a/docker/api/volume.py +++ b/docker/api/volume.py @@ -12,7 +12,7 @@ def volumes(self, filters=None): @utils.minimum_version('1.21') def create_volume(self, name, driver=None, driver_opts=None): - url = self._url('/volumes') + url = self._url('/volumes/create') if driver_opts is not None and not isinstance(driver_opts, dict): raise TypeError('driver_opts must be a dictionary') diff --git a/tests/fake_api.py b/tests/fake_api.py index 214b197d64..8852da02c5 100644 --- a/tests/fake_api.py +++ b/tests/fake_api.py @@ -529,7 +529,7 @@ def fake_remove_volume(): get_fake_events, ('{1}/{0}/volumes'.format(CURRENT_VERSION, prefix), 'GET'): get_fake_volume_list, - ('{1}/{0}/volumes'.format(CURRENT_VERSION, prefix), 'POST'): + ('{1}/{0}/volumes/create'.format(CURRENT_VERSION, prefix), 'POST'): get_fake_volume, ('{1}/{0}/volumes/{2}'.format( CURRENT_VERSION, prefix, FAKE_VOLUME_NAME diff --git a/tests/test.py b/tests/test.py index 20ec88cf97..86f1941ceb 100644 --- a/tests/test.py +++ b/tests/test.py @@ -2208,7 +2208,7 @@ def test_create_volume(self): args = fake_request.call_args self.assertEqual(args[0][0], 'POST') - self.assertEqual(args[0][1], url_prefix + 'volumes') + self.assertEqual(args[0][1], url_prefix + 'volumes/create') self.assertEqual(json.loads(args[1]['data']), {'Name': name}) @base.requires_api_version('1.21') @@ -2219,7 +2219,7 @@ def test_create_volume_with_driver(self): args = fake_request.call_args self.assertEqual(args[0][0], 'POST') - self.assertEqual(args[0][1], url_prefix + 'volumes') + self.assertEqual(args[0][1], url_prefix + 'volumes/create') data = json.loads(args[1]['data']) self.assertIn('Driver', data) self.assertEqual(data['Driver'], driver_name)